Uh oh!
There was an error while loading. Please reload this page.
UnderlineNav2: Add transparent outline for focus ring to support WHCM - #3165
Merged
Conversation
🦋 Changeset detectedLatest commit: f7ca3dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
broccolinisoup
temporarily deployed
to
github-pages
April 13, 2023 06:08 — with 
GitHub Actions
Inactive
joshblack
approved these changes
Apr 13, 2023
This was referenced Apr 13, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It came up on
PageHeaderaccessibility sign-off review that theUnderlineNavlinks' focus rings are not visible on the Window High Contrast Theme. Added a transparent outline as suggested.Closeshttps://github.com/github/primer/issues/2081 (Hubbers only link)
Screenshots
Before
After
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.