Uh oh!
There was an error while loading. Please reload this page.
Add pullQueued state to StateLabel - #3244
Conversation
🦋 Changeset detectedLatest commit: 1b976ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Josh Black <joshblack@github.com>
talum
commented
May 2, 2023
🔥 great work @Bestra! |
joshblack
commented
May 2, 2023
Just wanted to request your review @danielguillan from the design side for this change 👀 Let me know if there would be someone better to bring in! Just was using the first responder rotation this week. |
joshblack
left a comment
There was a problem hiding this comment.
Looks great! Thanks for putting this together 🥳 Just needs a +1 from design and should be good to go.
danielguillan
left a comment
There was a problem hiding this comment.
This looks good to me! I'm adding @lukasoppermann to double check as he's been working on Primer Labels recently.
lukasoppermann
commented
May 3, 2023
Hey, thanks for bringing this up. One question, is there any specific reasoning behind the color? Or was it mainly that the other ones are used already? |
Bestra
commented
May 3, 2023
@lukasoppermann Looking back through the issue history I think we're attempting to match the merge queue icon color from |
Adds the
pullQueuedstate to theStateLabelcomponent.Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.