Skip to content

Add pullQueued state to StateLabel - #3244

Merged
joshblack merged 4 commits into
primer:mainfrom
Bestra:bestra/add-queued-statelabel
May 4, 2023
Merged

Add pullQueued state to StateLabel#3244
joshblack merged 4 commits into
primer:mainfrom
Bestra:bestra/add-queued-statelabel

Conversation

@Bestra

@BestraBestra commented May 1, 2023

Copy link
Copy Markdown
Contributor

Adds the pullQueued state to the StateLabel component.

Screenshots

image

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot

changeset-botBot commented May 1, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1b976ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactMinor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Bestra
Bestra temporarily deployed to github-pages May 1, 2023 19:03 — with GitHub Actions Inactive
@Bestra
Bestra temporarily deployed to github-pages May 1, 2023 19:14 — with GitHub Actions Inactive
@Bestra
Bestra temporarily deployed to github-pages May 1, 2023 19:50 — with GitHub Actions Inactive
@Bestra
Bestra marked this pull request as ready for review May 1, 2023 20:05
@Bestra
Bestra requested review from a team and josepmartinsMay 1, 2023 20:05

@joshblackjoshblack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for opening up this PR! 🥳 Just left a small question as a comment 👀

Comment threaddocs/content/StateLabel.mdx Outdated
Co-authored-by: Josh Black <joshblack@github.com>
@talum

talum commented May 2, 2023

Copy link
Copy Markdown
Contributor

🔥 great work @Bestra!

@joshblack

Copy link
Copy Markdown
Member

Just wanted to request your review @danielguillan from the design side for this change 👀 Let me know if there would be someone better to bring in! Just was using the first responder rotation this week.

@joshblackjoshblack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for putting this together 🥳 Just needs a +1 from design and should be good to go.

@danielguillandanielguillan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I'm adding @lukasoppermann to double check as he's been working on Primer Labels recently.

@lukasoppermann

Copy link
Copy Markdown
Contributor

Hey, thanks for bringing this up. One question, is there any specific reasoning behind the color? Or was it mainly that the other ones are used already?

@Bestra

Copy link
Copy Markdown
ContributorAuthor

One question, is there any specific reasoning behind the color?

@lukasoppermann Looking back through the issue history I think we're attempting to match the merge queue icon color from
https://github.com/github/primer/issues/295, but I can't speak to the rationale beyond that.

@joshblack
joshblack added this pull request to the merge queueMay 4, 2023
Merged via the queue into primer:main with commit 42a78c1May 4, 2023
@primer-cssprimer-css mentioned this pull request May 4, 2023
@Bestra
Bestra deleted the bestra/add-queued-statelabel branch May 5, 2023 10:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Bestra@talum@joshblack@lukasoppermann@danielguillan