Skip to content

refactor(ActionList): import merge from sx - #3271

Merged
joshblack merged 2 commits into
mainfrom
fix/add-lodash-merge
May 10, 2023
Merged

refactor(ActionList): import merge from sx#3271
joshblack merged 2 commits into
mainfrom
fix/add-lodash-merge

Conversation

@joshblack

Copy link
Copy Markdown
Member

Currently, ActionList imports the merge utility from lodash. This causes a downstream bundle increase since lodash is being brought in. This PR updates the usage to bring in merge from the sx module to avoid bringing in merge from lodash

@joshblack
joshblack requested review from a team and colebemisMay 10, 2023 17:05
@changeset-bot

changeset-botBot commented May 10, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 30becd2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblackjoshblack added the skip changeset This change does not need a changelog label May 10, 2023
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
dist/browser.esm.js96.35 KB (-20.81% 🔽)
dist/browser.umd.js96.84 KB (-20.57% 🔽)

@joshblack
joshblack added this pull request to the merge queueMay 10, 2023
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks May 10, 2023
@joshblack
joshblack added this pull request to the merge queueMay 10, 2023
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks May 10, 2023
@joshblack
joshblack added this pull request to the merge queueMay 10, 2023
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks May 10, 2023
@joshblack
joshblack added this pull request to the merge queueMay 10, 2023
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks May 10, 2023
@joshblack
joshblack added this pull request to the merge queueMay 10, 2023
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks May 10, 2023
@joshblack
joshblack added this pull request to the merge queueMay 10, 2023
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks May 10, 2023
@joshblack
joshblack added this pull request to the merge queueMay 10, 2023
Merged via the queue into main with commit 102ea81May 10, 2023
@joshblack
joshblack deleted the fix/add-lodash-merge branch May 10, 2023 21:29
@joshblackjoshblack mentioned this pull request May 11, 2023
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changesetThis change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@joshblack@radglob@colebemis