Uh oh!
There was an error while loading. Please reload this page.
CounterLabel should forward ref and dom props - #3291
Merged
Conversation
🦋 Changeset detectedLatest commit: e7cbc86 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
mattcosta7
commented
May 16, 2023
| sx, | ||
| )} | ||
| {...props} | ||
| as="span" |
ContributorAuthor
There was a problem hiding this comment.
we don't pass as through (in ts land) so avoiding it getting passed through by non-ts code
mattcosta7force-pushed
the
counter-label-should-forward-refs
branch
from
May 16, 2023 20:51
fbb5a61 to
6468085Comparejoshblack
approved these changes
May 17, 2023
joshblack
left a comment
Member
There was a problem hiding this comment.
Looks great! Just had a style question and wanted to hear what your thoughts were 👀
mattcosta7
commented
May 18, 2023
ContributorAuthor
I don't see the question! |
This was referenced May 18, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CounterLabel should forward both dom props and refs tot he underlying box
Closes # (type the issue number after # if applicable; otherwise remove this line)
Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.