Uh oh!
There was an error while loading. Please reload this page.
Button & Link Updates - #330
Conversation
This pull request is automatically deployed with Now. |
Uh oh!
There was an error while loading. Please reload this page.
| }) | ||
| const styledLink = styled('a')` | ||
| const Link = ({is: Tag, children, ...rest}) => { |
There was a problem hiding this comment.
I did this because I couldn't figure out how to pass a dynamic tag based on a prop to styled
| } | ||
| <a | ||
| blacklist={ |
There was a problem hiding this comment.
@shawnbot do you know why this is happened and if it's okay or not? I think it has something to do with calling styled(Link) instead of styled('a') but I'm not positive 🤔
There was a problem hiding this comment.
I don't know, but I'm 90% sure it's a system-components thing. Maybe we could use clean-tag if we just want to keep those attributes out of the resulting DOM? 🤔
shawnbot
left a comment
There was a problem hiding this comment.
Code looks great, thanks for this!
widthpropblockprop on ButtonButtonLink- users should use a<Link is='button'>for this use case. The model here should beButtonis a UI element that is styled like a button.Linkis a UI element that is styled like a link. You can change the tag as needed.Closes#312
Merge checklist