Uh oh!
There was an error while loading. Please reload this page.
[docs only] Add octicons-react import to Octicon docs example - #3301
Conversation
|
broccolinisoup
left a comment
There was a problem hiding this comment.
👋🏻 @tomthorogood, sorry to hear about your experience! Great idea to add the import paths, thanks so much for that 🙏🏻
tomthorogood
commented
May 22, 2023
@broccolinisoup do you have any advice on how to correct the |
broccolinisoup
commented
May 22, 2023
👋🏻 @tomthorogood If you could run Re the changeset, I added |
broccolinisoup
commented
May 24, 2023
@tomthorogood I see in the diff there are version changes on the |
tomthorogood
commented
May 24, 2023
@broccolinisoup I assumed that was expected from running the format script; I didn't intend it, though. |
broccolinisoup
commented
May 25, 2023
@tomthorogood Interesting, as far as I know format running shouldn't cause a package-lock changes. Could you try removing it from the diff and make sure only the mdx changes come through? Thank you 🙏🏻 |
When reading through the
StyledOcticondocs, I had a hard time figuring out where to import the*Icons from, and had to grep the primer/react code base for bit before I found it. I figured this would help others from having to do the same.Merge checklist
[ ] Added/updated tests[ ] Changes are SSR compatible[ ] Tested in Chrome[ ] Tested in Firefox[ ] Tested in Safari[ ] Tested in EdgeTake a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.