Skip to content

SelectPanel: Add role="dialog" to overlay - #3310

Merged
colebemis merged 2 commits into
mainfrom
selectpanel-role-dialog
May 22, 2023
Merged

SelectPanel: Add role="dialog" to overlay#3310
colebemis merged 2 commits into
mainfrom
selectpanel-role-dialog

Conversation

@colebemis

@colebemiscolebemis commented May 22, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Add role="dialog" to the overlay rendered by SelectPanel

Part of https://github.com/github/primer/issues/2087

Screenshots

Before and after screenshot showing that role=dialog is properly applied

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot

changeset-botBot commented May 22, 2023•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5861103

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented May 22, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
dist/browser.esm.js116.18 KB (+0.01% 🔺)
dist/browser.umd.js118.04 KB (+0.01% 🔺)

@colebemis
colebemis temporarily deployed to github-pages May 22, 2023 18:28 — with GitHub Actions Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-3310 May 22, 2023 18:29 Inactive
@github-actions

github-actionsBot commented May 22, 2023

Copy link
Copy Markdown
Contributor

Uh oh! @colebemis, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

@colebemis
colebemis marked this pull request as ready for review May 22, 2023 20:21
@colebemis
colebemis requested review from a team and broccolinisoupMay 22, 2023 20:21
@github-actions
github-actionsBottemporarily deployed to storybook-preview-3310 May 22, 2023 20:26 Inactive
jonrohan
jonrohan approved these changes May 22, 2023
View reviewed changes

@jonrohanjonrohan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A+++ coder, would recommend 👍🏻

@colebemis
colebemis enabled auto-merge May 22, 2023 21:54
@colebemis
colebemis disabled auto-merge May 22, 2023 21:54
@colebemis
colebemis merged commit 5746c74 into mainMay 22, 2023
@colebemis
colebemis deleted the selectpanel-role-dialog branch May 22, 2023 21:54
This was referenced May 22, 2023
Merged
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonrohanjonrohanjonrohan approved these changes
@broccolinisoupbroccolinisoupAwaiting requested review from broccolinisoup

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@colebemis@jonrohan