Uh oh!
There was an error while loading. Please reload this page.
ActionList.Item: Check defaultPrevented between onSelect & afterSelect - #3314
Closed
siddharthkp wants to merge 4 commits into
Closed
ActionList.Item: Check defaultPrevented between onSelect & afterSelect#3314siddharthkp wants to merge 4 commits into
siddharthkp wants to merge 4 commits into
Conversation
🦋 Changeset detectedLatest commit: 85baf9f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6 tasks
Contributor
size-limit report 📦
|
joshblack
approved these changes
May 23, 2023
siddharthkp
commented
May 31, 2023
MemberAuthor
Don't need this anymore. Fixed in #3346 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<ActionList.Item>: event inonClickcan be canceled, but it cannot be canceled inonSelect#3162event.preventDefault()is called onActionList.Item'sonSelecthandler #3163Context: Today, if you want to customize the behaviour of a menu after selection (like in the video below) you have to opt out of
onSelectand implement it yourself usingonClickandonKeypressAs you can imagine, this can create bugs if not done well. This PR adds the ability to prevent the default behavior after onSelect by calling
event.preventDefaultinside it. (See newly added story for example)delay-actionmenu-afterselect.mov