Uh oh!
There was an error while loading. Please reload this page.
Accessibility engineering review for Link component. - #3317
Merged
Conversation
🦋 Changeset detectedLatest commit: 4aba402 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
lesliecdubs
commented
Jun 14, 2023
Member
@TylerJDev could you help out with a review on this one? Thanks! |
TylerJDev
approved these changes
Jun 14, 2023
TylerJDev
left a comment
Member
There was a problem hiding this comment.
Looks good to me! I think there's some pending discussion that'll need to be addressed first, but other than that I think that this is great!
Uh oh!
There was an error while loading. Please reload this page.
mperrotti
approved these changes
Jun 22, 2023
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
langermank
approved these changes
Jun 22, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restricting the
asprop in Link components. Leaving forcing underlining on links in text to more holistic changes.Closeshttps://github.com/github/primer/issues/1881
Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.