Uh oh!
There was an error while loading. Please reload this page.
Convert @primer/react to ESM, don't generate CommonJS bundle. - #3410
Convert @primer/react to ESM, don't generate CommonJS bundle.#3410radglob wants to merge 35 commits into
Conversation
🦋 Changeset detectedLatest commit: 4b752b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
joshblack
left a comment
There was a problem hiding this comment.
Looking great! Just left a comment for the package.json file itself 👀
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
joshblack
commented
Jun 20, 2023
@radglob just wanted to double check, I'm still not seeing |
radglob
commented
Jun 20, 2023
Yeah, that was a mistake on my part. I think I got distracted changing up the exports. |
joshblack
commented
Jul 27, 2023
Closing this out due to the technical limitations mentioned in: #3565 😞 Will make sure to use this as the base for any follow-up ESM work 🤞 |
Changed some configuration files to use
.cjsextension, others to use.mjsextension, and remove settings to produce CommonJS bundle.There are likely a lot more changes we could make (ex. only using
importinstead ofrequirein some places) but this seems to produce an ESM bundle and continues to work correctly in a toy project.Closes#2108.
Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.