Uh oh!
There was an error while loading. Please reload this page.
Let storybook be aware of postcss for .module.css files - #3518
Conversation
|
size-limit report 📦
|
langermank
left a comment
There was a problem hiding this comment.
Approving but would love for @siddharthkp to also approve before merging :)
broccolinisoup
left a comment
There was a problem hiding this comment.
This is very exciting! Thanks for this PR. It looks good to me but I am only watching the changes for now as I don't have much context and experience on this area as much as Sid or Katie has :)
| 'focus-visible-pseudo-class': false, | ||
| 'logical-properties-and-values': false, |
There was a problem hiding this comment.
Curious to hear why they are false 👀
There was a problem hiding this comment.
Took inspiration from https://github.com/primer/view_components/blob/main/postcss.config.js possibly @langermank can provide more insights
There was a problem hiding this comment.
I see @simurai/@jonrohan worked on this file and found some comments here: https://github.com/primer/view_components/pull/1638/files#r1032151244
Interesting stuff.
There was a problem hiding this comment.
In some of our cases, the output was putting more CSS than we needed for the browsers we supported. I think the focus-visible-pseudo-class was also adding a .focus class which was meant to be paired with JS. So it was on, until disabled.
Storybook's
addont-stylingwill autowire webpack for us to leverage css modules within our stories, and component files. Pathing the way to start using those as opposed to styled-components. We also prefer this addon now overstorybook-css-modules.Huge props to @siddharthkp for starting this work over in #3405
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.