Uh oh!
There was an error while loading. Please reload this page.
NavList: Fix when subNav opens automatically and shows current indicator - #3611
Merged
Conversation
🦋 Changeset detectedLatest commit: 8b84b33 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
siddharthkp
requested review from
joshblack
and removed request for
broccolinisoupAugust 9, 2023 14:59
Contributor
size-limit report 📦
|
langermank
approved these changes
Aug 11, 2023
joshblack
approved these changes
Aug 11, 2023
broccolinisoup
approved these changes
Aug 14, 2023
This was referenced Aug 14, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: If the second item is selected, NavList does not open the subNav automatically and does not show current indicator at the subNav level when folded
before-navlist.mov
After: If the second item is selected, NavList does open subNav automatically and shows the current indicator at the subNav level
after-navlist.mov
Implementation detail
While we did check for
aria-current !== false, we did this for the first element witharia-current, which could be the one witharia-current=false:)Changing the selector to exclude false value takes care of this.