Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/empty-ears-fly.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
"@primer/react": patch
---

[Bug] Remove `flex` from Button labels

<!-- Changed components: Button -->
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 0 additions & 3 deletions src/Button/styles.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -298,9 +298,6 @@ export const getButtonStyles = (theme?: Theme) => {
gridArea: 'text',
lineHeight: 'calc(20/14)',
whiteSpace: 'nowrap',
// remove flex in next major release
display: 'flex',
alignItems: 'center',
},
'[data-component="trailingVisual"]': {
gridArea: 'trailingVisual',
Expand Down
8 changes: 0 additions & 8 deletions src/__tests__/__snapshots__/ActionMenu.test.tsx.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -178,14 +178,6 @@ exports[`ActionMenu renders consistently 1`] = `
grid-area: text;
line-height: calc(20/14);
white-space: nowrap;
display: -webkit-box;
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
-webkit-align-items: center;
-webkit-box-align: center;
-ms-flex-align: center;
align-items: center;
}

.c1 [data-component="trailingVisual"] {
Expand Down
64 changes: 0 additions & 64 deletions src/__tests__/__snapshots__/Button.test.tsx.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -164,14 +164,6 @@ exports[`Button renders consistently 1`] = `
grid-area: text;
line-height: calc(20/14);
white-space: nowrap;
display: -webkit-box;
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
-webkit-align-items: center;
-webkit-box-align: center;
-ms-flex-align: center;
align-items: center;
}

.c0 [data-component="trailingVisual"] {
Expand DownExpand Up@@ -405,14 +397,6 @@ exports[`Button respects block prop 1`] = `
grid-area: text;
line-height: calc(20/14);
white-space: nowrap;
display: -webkit-box;
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
-webkit-align-items: center;
-webkit-box-align: center;
-ms-flex-align: center;
align-items: center;
}

.c0 [data-component="trailingVisual"] {
Expand DownExpand Up@@ -652,14 +636,6 @@ exports[`Button respects the alignContent prop 1`] = `
grid-area: text;
line-height: calc(20/14);
white-space: nowrap;
display: -webkit-box;
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
-webkit-align-items: center;
-webkit-box-align: center;
-ms-flex-align: center;
align-items: center;
}

.c0 [data-component="trailingVisual"] {
Expand DownExpand Up@@ -898,14 +874,6 @@ exports[`Button respects the large size prop 1`] = `
grid-area: text;
line-height: calc(20/14);
white-space: nowrap;
display: -webkit-box;
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
-webkit-align-items: center;
-webkit-box-align: center;
-ms-flex-align: center;
align-items: center;
}

.c0 [data-component="trailingVisual"] {
Expand DownExpand Up@@ -1145,14 +1113,6 @@ exports[`Button respects the small size prop 1`] = `
grid-area: text;
line-height: calc(20/14);
white-space: nowrap;
display: -webkit-box;
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
-webkit-align-items: center;
-webkit-box-align: center;
-ms-flex-align: center;
align-items: center;
}

.c0 [data-component="trailingVisual"] {
Expand DownExpand Up@@ -1397,14 +1357,6 @@ exports[`Button styles danger button appropriately 1`] = `
grid-area: text;
line-height: calc(20/14);
white-space: nowrap;
display: -webkit-box;
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
-webkit-align-items: center;
-webkit-box-align: center;
-ms-flex-align: center;
align-items: center;
}

.c0 [data-component="trailingVisual"] {
Expand DownExpand Up@@ -1652,14 +1604,6 @@ exports[`Button styles invisible button appropriately 1`] = `
grid-area: text;
line-height: calc(20/14);
white-space: nowrap;
display: -webkit-box;
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
-webkit-align-items: center;
-webkit-box-align: center;
-ms-flex-align: center;
align-items: center;
}

.c0 [data-component="trailingVisual"] {
Expand DownExpand Up@@ -1914,14 +1858,6 @@ exports[`Button styles primary button appropriately 1`] = `
grid-area: text;
line-height: calc(20/14);
white-space: nowrap;
display: -webkit-box;
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
-webkit-align-items: center;
-webkit-box-align: center;
-ms-flex-align: center;
align-items: center;
}

.c0 [data-component="trailingVisual"] {
Expand Down
24 changes: 0 additions & 24 deletions src/__tests__/__snapshots__/TextInput.test.tsx.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -1803,14 +1803,6 @@ exports[`TextInput renders trailingAction icon button 1`] = `
grid-area: text;
line-height: calc(20/14);
white-space: nowrap;
display: -webkit-box;
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
-webkit-align-items: center;
-webkit-box-align: center;
-ms-flex-align: center;
align-items: center;
}

.c4 [data-component="trailingVisual"] {
Expand DownExpand Up@@ -2460,14 +2452,6 @@ exports[`TextInput renders trailingAction text button 1`] = `
grid-area: text;
line-height: calc(20/14);
white-space: nowrap;
display: -webkit-box;
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
-webkit-align-items: center;
-webkit-box-align: center;
-ms-flex-align: center;
align-items: center;
}

.c3 [data-component="trailingVisual"] {
Expand DownExpand Up@@ -2871,14 +2855,6 @@ exports[`TextInput renders trailingAction text button with a tooltip 1`] = `
grid-area: text;
line-height: calc(20/14);
white-space: nowrap;
display: -webkit-box;
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
-webkit-align-items: center;
-webkit-box-align: center;
-ms-flex-align: center;
align-items: center;
}

.c4 [data-component="trailingVisual"] {
Expand Down