Uh oh!
There was an error while loading. Please reload this page.
Default stories for Page header do not link correctly. - #3670
Conversation
- Currently the default stories for pageheader do not link correctly. - Made changes accordingly so that the storybook link correctly.
|
joshblack
commented
Aug 28, 2023
Thanks for tackling this @electron97! |
joshblack
commented
Aug 28, 2023
Hmm, based on the validation it seems like the cc @siddharthkp it seems like this file is marked |
broccolinisoup
commented
Aug 29, 2023
@joshblack 👋🏻 I was reviewing this PR and the tests failed and I think it is because of the same reason you mentioned above that it is not a feature story id. From what I understand, we generate default story id for each component and it doesn't take component status into account if I am reading this right I wonder if such fix would resolve this? 🤔 |
joshblack
commented
Sep 5, 2023
@broccolinisoup ooo I think it would! Let me know when that PR is good to go, it will help out a ton 🥳 |
broccolinisoup
commented
Oct 3, 2023
#3670 fixes the default story id for components that are not in the main bundle (i.e. drafts, deprecated etc) With #3670 is out, PageHeader docs are now rendered correctly 🎉 I'm closing this PR but please let me know if there is any concern 🙌🏻 |
PageHeader.docs.jsonso that it link the storybook stories correctly.Closes#3669