Uh oh!
There was an error while loading. Please reload this page.
fix(ActionList): place id on item with role - #3691
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 0a60663 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
dusave
approved these changes
Aug 30, 2023
mperrotti
approved these changes
Aug 30, 2023
mperrotti
left a comment
Contributor
There was a problem hiding this comment.
CI should pass after updating snapshots.
joshblack
temporarily deployed
to
github-pages
September 6, 2023 20:28 — with 
GitHub Actions
Inactive
joshblack
commented
Sep 7, 2023
MemberAuthor
@dusave checking upstream, it doesn't seem like this change introduces a regression so it could be safe to land. Wanted to double-check with you to see how you felt about this change. I'll also ask the team to see if we're okay with this kind of change in a current minor release 👀 |
joshblack
temporarily deployed
to
github-pages
September 7, 2023 16:10 — with GitHub Actions
Inactive
This was referenced Oct 10, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: https://github.slack.com/archives/C01L618AEP9/p1693422238328979
The
idonActionList.Itemshould be placed on the item with the corresponding ARIA role so that a consumer can use that value to manage attributes likearia-activedescendantappropriately.