Skip to content

chore(dependencies): Upgrade @primer/octicons-react to v19.7.0#3692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
broccolinisoup merged 1 commit into from
Sep 4, 2023
Merged

chore(dependencies): Upgrade @primer/octicons-react to v19.7.0 #3692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/lazy-bees-train.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
'@primer/react': minor
---

Octicons: Upgrade react-octicons to v19.7.0

<!-- Changed components: _none_ -->
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -100,7 +100,7 @@
"@github/relative-time-element": "^4.1.2",
"@lit-labs/react": "^2.0.1",
"@primer/behaviors": "^1.3.4",
"@primer/octicons-react": "^19.3.0",
"@primer/octicons-react": "^19.7.0",

@broccolinisoupbroccolinisoupSep 1, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: I also have an upgrade PR at dotcom https://github.com/github/github/pull/286206 as well and in the diff, there are so many icons in node_modules/@primer/react/node_modules/@primer/octicons-react are deleted. I am a bit confused by this. Does that happen because of npm workspaces that these icons are coming from node_modules/@primer/octicons-react?

@joshblackjoshblackSep 1, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@broccolinisoup I think you're right, now that @primer/octicons-react can properly be hoisted we're now seeing all of the ones in the nested node_modules being removed.

"@primer/primitives": "^7.11.11",
"@react-aria/ssr": "^3.5.0",
"@styled-system/css": "^5.1.5",
Expand Down