Uh oh!
There was an error while loading. Please reload this page.
Add sparse sorting to DataTable - #3749
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 1e57e9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
thyeggman
temporarily deployed
to
github-pages
September 18, 2023 17:46 — with 
GitHub Actions
Inactive
thyeggman
temporarily deployed
to
github-pages
September 18, 2023 18:19 — with GitHub Actions
Inactive
thyeggmanforce-pushed
the
thyeggman/sparse-sorting
branch
from
September 18, 2023 18:31
04784ec to
2ec78c1Comparethyeggman
temporarily deployed
to
github-pages
September 18, 2023 18:36 — with GitHub Actions
Inactive
thyeggmanforce-pushed
the
thyeggman/sparse-sorting
branch
from
September 18, 2023 20:22
2ec78c1 to
f586f10Comparethyeggman
temporarily deployed
to
github-pages
September 18, 2023 20:29 — with GitHub Actions
Inactive
lesliecdubs
requested review from
joshblack
and removed request for
joshblackSeptember 21, 2023 00:02
joshblack
approved these changes
Sep 25, 2023
joshblack
left a comment
Member
There was a problem hiding this comment.
Thanks so much for the contribution! 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows sorting of sparse columns. When sorting by a sparse column, all blank values are ordered last regardless of the sort direction.
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.
Co-authored by @joshblack