fix(Link): update underline={false} to disable underline

[joshblack]

This is a follow-up to the latest release which included support for underline preference in the Link component: #3720

I noticed when trying to update code upstream that underline={false} does not work with this preference enabled. This PR changes this behavior so that underline={false} is respected regardless of if the preference is enabled.

I'm curious what folks feel about this change 🤔 I couldn't think of an alternative if someone wanted to disable underlines in a specific area (like for cards in a project).

Changelog

New

Changed

• Update underline={false} branch in Link to set text-decoration to 'none' if the value is false
• Add No Underline Link story
• Add e2e tests for No underline Link story

Removed

Rollout strategy

• Patch release

[changeset-bot]

🦋 Changeset detected

Latest commit: 4963ae7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/browser.esm.js	104.78 KB (+0.01% 🔺)
dist/browser.umd.js	105.36 KB (+0.01% 🔺)

[mperrotti]

I'm curious what folks feel about this change 🤔 I couldn't think of an alternative if someone wanted to disable underlines in a specific area (like for cards in a project).

I really like this approach. The only thing that feels a little strange is that we don't usually differentiate between an undefined (or falsey) prop value and an explicit false prop value.

[mperrotti]

I pushed a commit to update src/Link/Link.docs.json. Feel free to drop it or push new changes.

[joshblack]

Superseded by: #3946