Uh oh!
There was an error while loading. Please reload this page.
refactor Dialog to use <dialog> internally - #3840
Closed
keithamus wants to merge 2 commits into
Closed
Conversation
🦋 Changeset detectedLatest commit: 51c8194 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
keithamus
temporarily deployed
to
github-pages
October 18, 2023 11:52 — with 
GitHub Actions
Inactive
keithamusforce-pushed
the
refactor-dialog-to-use-dialog-internally
branch
2 times, most recently
from
October 23, 2023 14:06
e90fb09 to
92a5e9cComparekeithamus
temporarily deployed
to
github-pages
October 23, 2023 14:12 — with GitHub Actions
Inactive
keithamusforce-pushed
the
refactor-dialog-to-use-dialog-internally
branch
from
October 23, 2023 15:13
92a5e9c to
1f2d335Comparekeithamus
temporarily deployed
to
github-pages
October 23, 2023 15:21 — with GitHub Actions
Inactive
keithamusforce-pushed
the
refactor-dialog-to-use-dialog-internally
branch
from
October 24, 2023 09:36
1f2d335 to
4ec1f2bCompareContributor
size-limit report 📦
|
keithamus
temporarily deployed
to
github-pages
October 24, 2023 09:43 — with GitHub Actions
Inactive
keithamusforce-pushed
the
refactor-dialog-to-use-dialog-internally
branch
from
October 25, 2023 08:44
4ec1f2b to
b12480dComparekeithamus
temporarily deployed
to
github-pages
October 25, 2023 08:52 — with GitHub Actions
Inactive
keithamusforce-pushed
the
refactor-dialog-to-use-dialog-internally
branch
from
October 27, 2023 09:53
b12480d to
54820e7Comparekeithamus
temporarily deployed
to
github-pages
October 27, 2023 10:00 — with GitHub Actions
Inactive
keithamusforce-pushed
the
refactor-dialog-to-use-dialog-internally
branch
from
October 27, 2023 10:33
54820e7 to
2e21933Comparekeithamus
temporarily deployed
to
github-pages
October 27, 2023 10:41 — with GitHub Actions
Inactive
keithamusforce-pushed
the
refactor-dialog-to-use-dialog-internally
branch
from
October 27, 2023 11:06
2e21933 to
fbe8372Comparekeithamus
temporarily deployed
to
github-pages
October 27, 2023 11:13 — with GitHub Actions
Inactive
keithamusforce-pushed
the
refactor-dialog-to-use-dialog-internally
branch
2 times, most recently
from
November 2, 2023 16:37
ca66c14 to
85cbf4aComparekeithamusforce-pushed
the
refactor-dialog-to-use-dialog-internally
branch
from
December 7, 2023 12:18
eec3b55 to
8c1a4f4Comparekeithamusforce-pushed
the
refactor-dialog-to-use-dialog-internally
branch
from
December 7, 2023 12:22
8c1a4f4 to
62db52aComparekeithamusforce-pushed
the
refactor-dialog-to-use-dialog-internally
branch
from
December 7, 2023 14:15
62db52a to
8e8afffComparesiddharthkptemporarily deployed
to
github-pages
December 7, 2023 14:36 — with GitHub Actions
Inactive
siddharthkptemporarily deployed
to
github-pages
December 7, 2023 15:05 — with GitHub Actions
Inactive
siddharthkptemporarily deployed
to
github-pages
December 7, 2023 15:20 — with GitHub Actions
Inactive
keithamusforce-pushed
the
refactor-dialog-to-use-dialog-internally
branch
from
December 8, 2023 14:27
46179aa to
a9e6040Comparekeithamusforce-pushed
the
refactor-dialog-to-use-dialog-internally
branch
2 times, most recently
from
December 8, 2023 14:32
b5151ba to
a5033c6CompareContributor
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
1 similar comment
Contributor
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs https://github.com/github/primer/issues/2531
This changes
Dialogto use the<dialog>element internally, which allows us to delete a fair amount of code and should resolve some bugs and complexity we have with the current dialog.Changelog
New
Changed
Dialognow uses native<dialog>under the hood.Removed
Rollout strategy
Testing & Reviewing
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.