Dialog: Add sx styles back to the footer styled-component & add visual regression tests for both Dialogs

[broccolinisoup]

Caught an issue on the dotcom integration tests where our dialog was showing the footer when it is not supposed to. (file reference). It turns out the sx prop wasn't applied in the below code. I think #3918 introduced a regression. I believeremoving the sx styles from the footer styled-component wasn't intentional.

<Dialog.Footer sx={{display: displayMode === DisplayMode.IssueCreation ? 'flex' : 'none'}}>
<CreateIssueFooter onClose={() => onSafeClose()} />
</Dialog.Footer>

Before	After

Changelog

New

Added visual regression tests for Dialog and Dialog1. (We should be able to catch these issues on our end before merged now 🤗)

Changed

Added the sx styles back to the styled footer.

Removed

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

Can be looked into the custom rendering story and make sure the sx styles are applied.

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• Integration tests pass at github/github (Learn more about how to run integration tests)

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

🦋 Changeset detected

Latest commit: f2375ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/browser.esm.js	104.21 KB (+0.01% 🔺)
dist/browser.umd.js	104.75 KB (+0.01% 🔺)

[dylanatsmith]

Oof, sorry about this! Good catch.

[joshblack]

These should help with the timeouts 🤞

[pksjce]

Love the tests! 🥳