Uh oh!
There was an error while loading. Please reload this page.
Use aria-required instead of required on required form elements - #4023
Merged
Conversation
🦋 Changeset detectedLatest commit: 1600730 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
mperrotti
commented
Dec 5, 2023
ContributorAuthor
This was opened as a draft PR to address a problem with inputs using HTML5 browser-native validation because of the Here are two possible alternatives to these changes:
|
camertron
approved these changes
Dec 7, 2023
mperrotti
marked this pull request as ready for review
December 7, 2023 21:53
joshblack
approved these changes
Dec 8, 2023
Merged
TylerJDev pushed a commit
that referenced
this pull request
Dec 11, 2023
…4023) * sets aria-required attr instead of required * Create khaki-rules-breathe.md
13 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added later by @siddharthkp: Hi 👋 This change was to workaround native browser validation errors. aria-required communicates the same message and was approved by the a11y team 👍.
Closes #
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.