Skip to content

Revert "SelectPanel2: Use html dialog" - #4099

Closed
broccolinisoup wants to merge 1 commit into
mainfrom
revert-4020-drafts-selectpanel-html-dialog
Closed

Revert "SelectPanel2: Use html dialog"#4099
broccolinisoup wants to merge 1 commit into
mainfrom
revert-4020-drafts-selectpanel-html-dialog

Conversation

@broccolinisoup

@broccolinisoupbroccolinisoup commented Dec 21, 2023

Copy link
Copy Markdown
Member

Reverts #4020

@broccolinisoup
broccolinisoup requested review from a team and siddharthkpDecember 21, 2023 03:36
@changeset-bot

changeset-botBot commented Dec 21, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2d36acf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actionsBot commented Dec 21, 2023

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
dist/browser.esm.js104.87 KB (0%)
dist/browser.umd.js105.44 KB (0%)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-4099 December 21, 2023 03:40 Inactive
@siddharthkpsiddharthkp self-assigned this Dec 21, 2023
@mperrotti

mperrotti commented Dec 21, 2023

Copy link
Copy Markdown
Contributor

What happened? Why did we have to revert?

@broccolinisoup

broccolinisoup commented Dec 22, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

What happened? Why did we have to revert?

Sorry @mperrotti for not providing details on the revert! The new dialog was breaking dotcom tests and I created this PR to test the release without the SelectPanel changes. After all, @siddharthkp found a solution (GitHub staff only link) to fix the tests so we are not reverting the PR 🎉 I'm closing this.

@broccolinisoup
broccolinisoup deleted the revert-4020-drafts-selectpanel-html-dialog branch December 22, 2023 00:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siddharthkpsiddharthkpAwaiting requested review from siddharthkp

Assignees

@siddharthkpsiddharthkp

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@broccolinisoup@mperrotti@siddharthkp