Skip to content

SelectPanel2: Add modal variant - #4120

Merged
siddharthkp merged 8 commits into
mainfrom
drafts-selectpanel-modal
Jan 22, 2024
Merged

SelectPanel2: Add modal variant#4120
siddharthkp merged 8 commits into
mainfrom
drafts-selectpanel-modal

Conversation

@siddharthkp

@siddharthkpsiddharthkp commented Jan 5, 2024•
edited
Loading

Copy link
Copy Markdown
Member
  • Add modal variant
  • Add modal story to features
  • Update examples story for opening modal SelectPanel from ActionMenu
SelectPanel anchored variant (default)SelectPanel modal variant
SelectPanel is in the centre of the screenSelectPanel is anchored to the button

@siddharthkpsiddharthkp self-assigned this Jan 5, 2024
@changeset-bot

This comment was marked as resolved.

Sign in to view
@github-actions

github-actionsBot commented Jan 5, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
dist/browser.esm.js104.96 KB (0%)
dist/browser.umd.js105.53 KB (0%)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-4120 January 5, 2024 11:16 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4120 January 5, 2024 11:57 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4120 January 5, 2024 12:10 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4120 January 12, 2024 20:52 Inactive
@siddharthkpsiddharthkp changed the title SelectPanel2: Add variant: modalSelectPanel2: Add modal variantJan 12, 2024
@siddharthkp
siddharthkp marked this pull request as ready for review January 12, 2024 20:53
@siddharthkp
siddharthkp requested a review from a teamJanuary 12, 2024 20:53
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4120 January 12, 2024 20:56 Inactive
broccolinisoup
broccolinisoup approved these changes Jan 15, 2024
View reviewed changes

@broccolinisoupbroccolinisoup left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool ✨

@siddharthkp
siddharthkp added this pull request to the merge queueJan 22, 2024
Merged via the queue into main with commit cbdd98aJan 22, 2024
@siddharthkp
siddharthkp deleted the drafts-selectpanel-modal branch January 22, 2024 18:13
@primerprimerBot mentioned this pull request Jan 22, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@broccolinisoupbroccolinisoupbroccolinisoup approved these changes
+1 more reviewer
@mperrottimperrottimperrotti approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@siddharthkpsiddharthkp

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siddharthkp@broccolinisoup@mperrotti