Uh oh!
There was an error while loading. Please reload this page.
SelectPanel2: Fix bug calling onCancel - #4131
Merged
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
size-limit report 📦
|
siddharthkptemporarily deployed
to
github-pages
January 9, 2024 14:32 — with 
GitHub Actions
Inactive
siddharthkp
marked this pull request as ready for review
January 12, 2024 18:46
siddharthkp
commented
Jan 12, 2024
| const onInternalSubmit = (event?: React.FormEvent<HTMLFormElement>) => { | ||
| event?.preventDefault() // there is no event with selectionVariant=instant | ||
| if (propsOpen === undefined) setInternalOpen(false) |
MemberAuthor
There was a problem hiding this comment.
don't worry, this line is part of onInternalClose
siddharthkp
commented
Jan 12, 2024
| else dialogRef.current?.close() | ||
| // sync dialog open state (imperative) with internal component state | ||
| React.useEffect(() => { |
MemberAuthor
There was a problem hiding this comment.
Moved these statements into an effect to avoid conflict with the subsequent lines in the component in the same render
dialog was closing and then the other lines in the component would try to access dialogRef.current which throw an error on the console :)
siddharthkptemporarily deployed
to
github-pages
January 12, 2024 20:43 — with GitHub Actions
Inactive
mperrotti
approved these changes
Jan 18, 2024
Comment on lines
+167
to
+171
| React.useEffect(() => { | ||
| const dialogEl = dialogRef.current | ||
| dialogEl?.addEventListener('close', onInternalClose) | ||
| return () => dialogEl?.removeEventListener('close', onInternalClose) | ||
| }) |
There was a problem hiding this comment.
Do we need these effects to run every render? 🤔
MemberAuthor
There was a problem hiding this comment.
Good question! I'll double check
| import React from 'react' | ||
| import {ThemeProvider, ActionList} from '../../' | ||
| import {render, RenderResult} from '@testing-library/react' | ||
| import userEvent, {UserEvent} from '@testing-library/user-event' |
There was a problem hiding this comment.
Oo UserEvent type, I've never used it before 🔥
siddharthkptemporarily deployed
to
github-pages
January 22, 2024 18:06 — with GitHub Actions
Inactive
broccolinisoup
approved these changes
Jan 23, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: Calling
onSubmitcallsinternalClosewhich callsonCancel🐞!This PR fixes that by separating
internalCloseandinternalCancel