Uh oh!
There was an error while loading. Please reload this page.
Update Link inline prop description and deprecate underline - #4135
Merged
Conversation
🦋 Changeset detectedLatest commit: 5deac0e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
joshblack
requested changes
Jan 11, 2024
joshblack
left a comment
Member
There was a problem hiding this comment.
Thanks for doing this! Just left a comment on where @deprecated could live, hope it makes sense and let me know if you have any questions!
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Josh Black <joshblack@github.com>
dipree
commented
Jan 11, 2024
ContributorAuthor
@joshblack I see how that works now, thanks and updated. |
joshblack
approved these changes
Jan 12, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/github/primer/issues/2099
Updates the Link
inlineproperty description and set theunderlineproperty to "deprecated".