Uh oh!
There was an error while loading. Please reload this page.
SelectPanel2: Add SelectPanel.SecondaryAction - #4145
Merged
Conversation
siddharthkp
commented
Jan 13, 2024
Member
- Closeshttps://github.com/github/primer/issues/2379
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
size-limit report 📦
|
siddharthkptemporarily deployed
to
github-pages
January 13, 2024 19:30 — with 
GitHub Actions
Inactive
siddharthkp
marked this pull request as ready for review
January 13, 2024 19:33
siddharthkptemporarily deployed
to
github-pages
January 13, 2024 19:44 — with GitHub Actions
Inactive
| ) | ||
| } | ||
| const FooterContext = React.createContext(false) |
There was a problem hiding this comment.
minor: we should add a type to the context (probably it is in your to-do but just a reminder 🙂 )
| const SecondaryLink: React.FC<LinkProps> = props => { | ||
| return ( | ||
| // @ts-ignore TODO: is as prop is not recognised by button? |
There was a problem hiding this comment.
I think it is but maybe with "a" instead of Link?
MemberAuthor
There was a problem hiding this comment.
Nah, that also throws some type errors 🤔
Will put an task to triage and clean up at the end of the project!
mperrotti
approved these changes
Jan 18, 2024
broccolinisoup
approved these changes
Jan 23, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.