Uh oh!
There was an error while loading. Please reload this page.
refactor(react): remove circular dependencies - #4236
Merged
Conversation
🦋 Changeset detectedLatest commit: 3335d86 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
4 tasks
broccolinisoup
approved these changes
Feb 9, 2024
broccolinisoup
left a comment
Member
There was a problem hiding this comment.
This is great! Thanks so much for taking care of this ✨
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes circular dependencies that we have in
@primer/react. It also updates our rollup config to throw an error when we encounter one when bundling. Circular dependencies in an ESM context create issues where you are unable to use an imported identifier because it has not been defined in the module context yet.Changelog
New
Changed
src/index.tsand replaced them with imports directly to the moduleRemoved
Rollout strategy
Technically this should be a refactor and no behavior should change but, just to be safe, I think this should go out under a minor release to make sure
Testing & Reviewing