Add a new entry point as `next` and update draft Tooltip to export it from next by broccolinisoup · Pull Request #4250 · primer/react

broccolinisoup · 2024-02-10T02:11:20Z

Based on the Tooltip v2 adoption discussion, this PR adds a new entry point as next and export Tooltip from it with an updated documentation. The discussion is still open for feedback for docs consolidation, so please feel free to share any ideas/thoughts/concerns 🙌🏻

Changelog

New

next entry point

Changed

Renamed the draft/experimental Tooltip in docs and storybook to become Tooltip v2

Removed

Rollout strategy

Patch release
Minor release
Major release; if selected, include a written rollout or migration plan
None; if selected, include a brief description as to why

Testing & Reviewing

Is it clear why there are two version of Tooltips under the components?
Is it visible enough that the import path of Tooltip v2 is different than the usual import path?
Checking out the Tooltip and Tooltip v2 documentation and storybook and make sure they reflect the right version of the component
If possible testing the export would be great. i.e import {Tooltip} from '@primer/react/next' and make sure it imports the component properly.
Integration PR (Github stuff only)

Merge checklist

Added/updated tests
Added/updated documentation
Added/updated previews (Storybook)
Changes are SSR compatible
Tested in Chrome
Tested in Firefox
Tested in Safari
Tested in Edge
(GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

changeset-bot · 2024-02-10T02:11:23Z

🦋 Changeset detected

Latest commit: 6a0faea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-02-10T02:14:51Z

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	113.37 KB (-0.01% 🔽)
packages/react/dist/browser.umd.js	114.03 KB (+0.01% 🔺)

siddharthkp

🙌 This is coming together!

All the feedback is optional except for the docs preview. "Requested changes", feel free to DM me if I don't look at the notification once you make the changes

joshblack

LGTM for the next entrypoint! 👍 Will defer to @siddharthkp's comments for stories/location 👀

siddharthkp

Docs work now! Ship it

… from next (#4250) * Add a new entry point as and update draft Tooltip to export it from next * fix linting n add changeset * move the src code out of drafts and update docs * fix folder path and storyname * test(vrt): update snapshots * update tooltip's position to be absolute * Update docs/content/TooltipV2.mdx --------- Co-authored-by: broccolinisoup <broccolinisoup@users.noreply.github.com>

Add a new entry point as and update draft Tooltip to export it from next
08a67d2

broccolinisoup changed the title ~~Add a new entry point as and update draft Tooltip to export it from next~~Add a new entry point as next and update draft Tooltip to export it from nextFeb 10, 2024

broccolinisoup deployed to github-pages February 10, 2024 02:14 — with GitHub Actions View deployment

github-actionsBottemporarily deployed to storybook-preview-4250 February 10, 2024 02:15 Inactive

broccolinisoup mentioned this pull request Feb 10, 2024
add next entry point and move Tooltip there #4225
Closed
13 tasks

fix linting n add changeset
98a018a

broccolinisoup deployed to github-pages February 10, 2024 02:30 — with GitHub Actions View deployment

github-actionsBottemporarily deployed to storybook-preview-4250 February 10, 2024 02:31 Inactive

broccolinisoup marked this pull request as ready for review February 10, 2024 02:32

broccolinisoup requested review from a team and siddharthkp February 10, 2024 02:32

Merge branch 'main' into next-entry-point-tooltip
dbb8859

broccolinisoup deployed to github-pages February 12, 2024 08:23 — with GitHub Actions View deployment

github-actionsBottemporarily deployed to storybook-preview-4250 February 12, 2024 08:23 Inactive

broccolinisoup requested a review from joshblack February 12, 2024 09:46

broccolinisoup commented Feb 12, 2024
View reviewed changes

Comment threaddocs/content/TooltipV2.mdx Outdated

siddharthkp requested changes Feb 12, 2024
View reviewed changes

joshblack approved these changes Feb 12, 2024
View reviewed changes

broccolinisoup added 2 commits February 13, 2024 16:19

Merge branch 'main' into next-entry-point-tooltip
3274ee5

move the src code out of drafts and update docs
285900f

broccolinisoup deployed to github-pages February 14, 2024 03:00 — with GitHub Actions View deployment

github-actionsBottemporarily deployed to storybook-preview-4250 February 14, 2024 03:00 Inactive

broccolinisoup deployed to github-pages February 14, 2024 03:09 — with GitHub Actions View deployment

github-actionsBottemporarily deployed to storybook-preview-4250 February 14, 2024 03:09 Inactive

broccolinisoup deployed to github-pages February 14, 2024 04:22 — with GitHub Actions View deployment

github-actionsBottemporarily deployed to storybook-preview-4250 February 14, 2024 04:22 Inactive

broccolinisoup added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Feb 14, 2024

github-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Feb 14, 2024

primerBotdeployed to github-pages February 14, 2024 05:11 View deployment

github-actionsBottemporarily deployed to storybook-preview-4250 February 14, 2024 05:11 Inactive

fix folder path and storyname
2913c16

broccolinisoup force-pushed the next-entry-point-tooltip branch from 230c3a3 to 2913c16Compare February 14, 2024 05:22

broccolinisoup deployed to github-pages February 14, 2024 05:26 — with GitHub Actions View deployment

github-actionsBottemporarily deployed to storybook-preview-4250 February 14, 2024 05:26 Inactive

broccolinisoup added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Feb 14, 2024

test(vrt): update snapshots
b9962d2

github-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Feb 14, 2024

primerBotdeployed to github-pages February 14, 2024 06:10 View deployment

github-actionsBottemporarily deployed to storybook-preview-4250 February 14, 2024 06:10 Inactive

broccolinisoup requested a review from siddharthkp February 14, 2024 06:31

siddharthkp approved these changes Feb 14, 2024
View reviewed changes

broccolinisoup added 2 commits February 15, 2024 16:09

update tooltip's position to be absolute
2552c3c

Merge branch 'main' into next-entry-point-tooltip
edb6ca2

broccolinisoup deployed to github-pages February 15, 2024 06:21 — with GitHub Actions View deployment

github-actionsBottemporarily deployed to storybook-preview-4250 February 15, 2024 06:22 Inactive

broccolinisoup commented Feb 16, 2024
View reviewed changes

Comment threaddocs/content/TooltipV2.mdx

Update docs/content/TooltipV2.mdx
6a0faea

broccolinisoup deployed to github-pages February 16, 2024 05:05 — with GitHub Actions View deployment

github-actionsBottemporarily deployed to storybook-preview-4250 February 16, 2024 05:06 Inactive

broccolinisoup added this pull request to the merge queue Feb 18, 2024

Merged via the queue into main with commit f064534Feb 18, 2024

broccolinisoup deleted the next-entry-point-tooltip branch February 18, 2024 23:05

primerBot mentioned this pull request Feb 18, 2024
Release tracking #4281
Merged

broccolinisoup mentioned this pull request Feb 28, 2024
Tooltip: Take the position:absolute back and make sure the v1 and v2 ids are same for new docs #4317
Merged
13 tasks

primerBot mentioned this pull request Feb 28, 2024
Release tracking #4292
Merged

Navigation Menu

Uh oh!

Add a new entry point as `next` and update draft Tooltip to export it from next - #4250

Add a new entry point as `next` and update draft Tooltip to export it from next#4250
broccolinisoup merged 10 commits into
mainfrom
next-entry-point-tooltip

broccolinisoup commented Feb 10, 2024•
edited
Loading

Uh oh!

changeset-botBot commented Feb 10, 2024•
edited
Loading

Uh oh!

github-actionsBot commented Feb 10, 2024•
edited
Loading

Uh oh!

Uh oh!

siddharthkp left a comment •
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joshblack left a comment

Uh oh!

siddharthkp left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

broccolinisoup commented Feb 10, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

New

Changed

Removed

Rollout strategy

Testing & Reviewing

Merge checklist

Uh oh!

changeset-botBot commented Feb 10, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actionsBot commented Feb 10, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Uh oh!

siddharthkp left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joshblack left a comment

Choose a reason for hiding this comment

Uh oh!

siddharthkp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

broccolinisoup commented Feb 10, 2024•
edited
Loading

changeset-botBot commented Feb 10, 2024•
edited
Loading

github-actionsBot commented Feb 10, 2024•
edited
Loading

siddharthkp left a comment •
edited
Loading