Skip to content

simplify custom-element react bindings with util - #4346

Merged
keithamus merged 1 commit into
mainfrom
simplify-custom-element-react-bindings-with-util
Mar 5, 2024
Merged

simplify custom-element react bindings with util#4346
keithamus merged 1 commit into
mainfrom
simplify-custom-element-react-bindings-with-util

Conversation

@keithamus

@keithamus keithamus commented Mar 4, 2024

Copy link
Copy Markdown
Contributor

Closes #4347

Changelog

This is an internal change to add a private helper.

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

This is an internal change to add a private helper.

Testing & Reviewing

Merge checklist

@changeset-bot

changeset-bot Bot commented Mar 4, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 733dd84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Mar 4, 2024

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 113.72 KB (+0.12% 🔺)
packages/react/dist/browser.umd.js 114.38 KB (+0.12% 🔺)

@github-actions
github-actions Bot temporarily deployed to storybook-preview-4346 March 4, 2024 12:15 Inactive
@keithamus
keithamus force-pushed the simplify-custom-element-react-bindings-with-util branch from c600579 to 2ae37df Compare March 4, 2024 12:43
Comment thread packages/react/package.json
@keithamus
keithamus force-pushed the simplify-custom-element-react-bindings-with-util branch from 8709aaf to 733dd84 Compare March 5, 2024 12:28
@keithamus
keithamus marked this pull request as ready for review March 5, 2024 12:29
@keithamus
keithamus requested review from a team and langermank March 5, 2024 12:29
@github-actions
github-actions Bot temporarily deployed to storybook-preview-4346 March 5, 2024 12:32 Inactive
@keithamus
keithamus added this pull request to the merge queue Mar 5, 2024
Merged via the queue into main with commit 1610a15 Mar 5, 2024
@keithamus
keithamus deleted the simplify-custom-element-react-bindings-with-util branch March 5, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify custom-element react bindings with util

2 participants