Uh oh!
There was an error while loading. Please reload this page.
feat(SelectPanel): add support for announcements to SelectPanel.Loading - #4407
Merged
Conversation
🦋 Changeset detectedLatest commit: 6f0558a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
siddharthkp
approved these changes
Mar 19, 2024
siddharthkp
left a comment
Member
There was a problem hiding this comment.
Love it!
Left a tiny suggestion for changelog
Uh oh!
There was an error while loading. Please reload this page.
| const SelectPanelLoading= ({children = 'Fetching items...'}: React.PropsWithChildren) => { | ||
| return ( | ||
| <Box | ||
| <Status |
Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
…-to-select-panel-loading
joshblack
enabled auto-merge
March 19, 2024 16:34
Merged
lukasoppermann pushed a commit
that referenced
this pull request
Apr 16, 2024
…ng (#4407) * feat(SelectPanel): add support for announcements to SelectPanel.Loading * chore: add changeset * chore: run format * Update .changeset/rare-moose-destroy.md Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com> Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/github/primer/issues/3104
Add support for live region announcements to
SelectPanel.LoadingChangelog
New
SelectPanel.LoadingChanged
SelectPanel.Loadingto have optional childrenStatushelperRemoved
Rollout strategy
Testing & Reviewing
SelectPanel.Loadingannounce the given (or default) loading message