Uh oh!
There was an error while loading. Please reload this page.
chore(deps): update octicons-react and add range for primitives - #4417
Merged
Conversation
🦋 Changeset detectedLatest commit: ed68403 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
langermank
approved these changes
Mar 19, 2024
langermank
left a comment
Contributor
There was a problem hiding this comment.
Yay thank you! This bit me today in dotcom 😅
Contributor
size-limit report 📦
|
pksjce
approved these changes
Mar 20, 2024
broccolinisoup
approved these changes
Mar 20, 2024
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Mar 20, 2024
Uh oh!
There was an error while loading. Please reload this page.
Merged
lukasoppermann pushed a commit
that referenced
this pull request
Apr 16, 2024
* chore(deps): update octicons-react and add range for primitives * chore: add changeset * chore(project): update lockfile * chore(test): update snapshots * chore: try to increase timeout limits for ci --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
@primer/octicons-reactto the latest version. This PR also adds a range to both@primer/octicons-reactand@primer/primitivesto improve support downstream with monorepos. On our end, inpackage.jsonfiles we should specify the minimum version required for the package so that downstream users can more easily dedupe package versions.Changelog
New
Changed
@primer/octicons-reactto 19.9.0^range operator to@primerdependenciesRemoved
Rollout strategy
Testing & Reviewing