Skip to content

feat: add InlineMessage component - #4443

Merged
joshblack merged 28 commits into
mainfrom
feat/add-inline-message
Jun 11, 2024
Merged

feat: add InlineMessage component#4443
joshblack merged 28 commits into
mainfrom
feat/add-inline-message

Conversation

@joshblack

@joshblackjoshblack commented Mar 27, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Context https://github.com/github/primer/issues/3319

Changelog

New

  • Add InlineMessage component

Changed

Removed

Rollout strategy

  • Minor release

Testing & Reviewing

  • Verify component appearance and behavior based on usage docs
  • Evaluate component API, provide feedback if something is misaligned with system expectations

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Storybook)
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@changeset-bot

changeset-botBot commented Mar 27, 2024•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d642a62

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactMinor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joshblackjoshblack added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Mar 27, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4443 March 27, 2024 15:39 Inactive
@joshblackjoshblack added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 27, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4443 March 27, 2024 15:45 Inactive
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 27, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4443 March 27, 2024 15:51 Inactive
@github-actions

github-actionsBot commented Mar 27, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js89.45 KB (0%)
packages/react/dist/browser.umd.js89.79 KB (0%)

@joshblackjoshblack added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 27, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4443 March 27, 2024 20:00 Inactive
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 27, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4443 March 27, 2024 20:08 Inactive
@joshblackjoshblack added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jun 10, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4443 June 10, 2024 20:55 Inactive
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jun 10, 2024
@primer
primerBottemporarily deployed to github-pages June 10, 2024 21:02 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4443 June 10, 2024 21:02 Inactive
@lukasoppermannlukasoppermann mentioned this pull request Jun 11, 2024
Merged
@joshblackjoshblack added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jun 11, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4443 June 11, 2024 14:18 Inactive
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jun 11, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4443 June 11, 2024 14:24 Inactive
langermank
langermank approved these changes Jun 11, 2024
View reviewed changes

@langermanklangermank left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so good! ✨

@joshblack
joshblack added this pull request to the merge queueJun 11, 2024
Merged via the queue into main with commit f252337Jun 11, 2024
@joshblack
joshblack deleted the feat/add-inline-message branch June 11, 2024 14:53
@primerprimerBot mentioned this pull request Jun 11, 2024
Merged
@StemmlerSistersStemmlerSisters mentioned this pull request Jul 16, 2024
Open
@snyk-iosnyk-ioBot mentioned this pull request Jul 17, 2024
Open
@julitabarelkowskajulitabarelkowska mentioned this pull request Jul 17, 2024
Open
@CanadatechmanufacturingCanadatechmanufacturing mentioned this pull request Jul 17, 2024
Open
@snyk-iosnyk-ioBot mentioned this pull request Aug 13, 2024
Open
@Mapuppy09Mapuppy09 mentioned this pull request Aug 19, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukasoppermannlukasoppermannlukasoppermann approved these changes
+1 more reviewer
@langermanklangermanklangermank approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshblack@langermank@lukasoppermann