Skip to content

Release tracking - #4532

Merged
pksjce merged 1 commit into
mainfrom
changeset-release/main
May 1, 2024
Merged

Release tracking#4532
pksjce merged 1 commit into
mainfrom
changeset-release/main

Conversation

@primer

@primerprimerBot commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/react@36.17.0

Minor Changes

Patch Changes

@github-actions

Copy link
Copy Markdown
Contributor

❗ Pre-merge checklist

Please ensure these items are checked before merging.

🔎 Smoke test

  • All CI checks pass on this pull request
  • Docs and Storybook open in a browser
  • Works in CodeSandbox or StackBlitz
    • New components render successfully
    • (optional) Tested in both SPA and SSR apps if release contains build changes

🌏 Integration tests

  • Successful integration test with github/github as a primary consumer of Primer React (automated pull request)
    • Verify all CI checks have passed on automated pull request
    • Manually test critical paths in the review-lab
    • Manually test release-specific bugfixes and/or features work as described in the review-lab

🤔 Sanity test

  • All bugfixes in this release have resolved their corresponding issues
  • The issues for reverted PRs have been re-opened and commented on with a link to the reverted PR
  • No noticeable regressions have not been introduced as a result of changes in this release
  • Release notes accurately describe the changes made

🚢 After merge

  • Upgrade @primer/react version at github/github

  • Add the preview deployment's link to releases as a way of permalinking to old version's docs. Example

Please also leave any testing notes on the weekly release tracking issue. In particular, describing any issues encountered during your testing. This is helpful in providing historical context to the next release conductor as well as maintainers.

@github-actions

github-actionsBot commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js87.98 KB (0%)
packages/react/dist/browser.umd.js88.28 KB (0%)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-4532 April 24, 2024 14:18 Inactive
@primer
primerBotforce-pushed the changeset-release/main branch from e2b7b8a to 16e063dCompareApril 24, 2024 15:06
@primer
primerBot requested a review from a team as a code ownerApril 24, 2024 15:06
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4532 April 24, 2024 15:13 Inactive
@primer
primerBotforce-pushed the changeset-release/main branch from 16e063d to a634ee6CompareApril 24, 2024 16:40
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4532 April 24, 2024 16:44 Inactive
@primer
primerBotforce-pushed the changeset-release/main branch from a634ee6 to 64ac129CompareApril 25, 2024 14:59
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4532 April 25, 2024 15:03 Inactive
@pksjce

pksjce commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

We have integration tests passing for this release 🥳
https://github.com/github/github/pull/323061

@pksjce

Copy link
Copy Markdown
Contributor

Review lab looks sane 🎆

@pksjce
pksjce added this pull request to the merge queueApr 30, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Apr 30, 2024
@pksjce
pksjce added this pull request to the merge queueApr 30, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Apr 30, 2024
@pksjce

Copy link
Copy Markdown
Contributor

The merge queue seems to be spitting out this PR for some playwright test failures particularly in some themes of ActionList tests.
Ran these on local and it fails there too. I'm unable to determine whats the change that its complaining about. Is it the avatar because it has red dots on it in the diff image.
Here is an example
Actual:
ActionList-Block-Description-dark-dimmed-actual

Expected:
ActionList-Block-Description-dark-dimmed-expected

Diff:
ActionList-Block-Description-dark-dimmed-diff

@pksjce
pksjce added this pull request to the merge queueMay 1, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks May 1, 2024
@siddharthkp
siddharthkp added this pull request to the merge queueMay 1, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks May 1, 2024
@siddharthkpsiddharthkp added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label May 1, 2024
@primer
primerBot requested a review from a team as a code ownerMay 1, 2024 12:21
@primer
primerBot requested a review from tbenningMay 1, 2024 12:21
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label May 1, 2024
@github-actions
github-actionsBot requested a review from pksjceMay 1, 2024 12:22
@primer
primerBottemporarily deployed to github-pages May 1, 2024 12:24 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4532 May 1, 2024 12:25 Inactive
@pksjce
pksjce enabled auto-merge May 1, 2024 12:31
@primer
primerBotforce-pushed the changeset-release/main branch from 1117b93 to 42846c1CompareMay 1, 2024 17:45
@github-actions
github-actionsBot requested a review from pksjceMay 1, 2024 17:47
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4532 May 1, 2024 17:50 Inactive
@pksjce
pksjce added this pull request to the merge queueMay 1, 2024
Merged via the queue into main with commit 9018b32May 1, 2024
@pksjce
pksjce deleted the changeset-release/main branch May 1, 2024 18:04
lukasoppermann pushed a commit that referenced this pull request May 3, 2024
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pksjce@siddharthkp