tests: add missing snapshot and axe coverage for ActionMenu by khiga8 · Pull Request #4538 · primer/react

khiga8 · 2024-04-26T20:12:46Z

Changelog

I noticed that most of the snapshots test and axe scan coverage for ActionMenu are for the default closed state, which is just a button.

This PR adds an action to open the ActionMenu to ensure we're getting adequate visual regression and axe testing coverage, and regenerates the snapshots.

Rollout strategy

Patch release
Minor release
Major release; if selected, include a written rollout or migration plan
None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Added/updated tests
Added/updated documentation
Added/updated previews (Storybook)
Changes are SSR compatible
Tested in Chrome
Tested in Firefox
Tested in Safari
Tested in Edge
(GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

changeset-bot · 2024-04-26T20:12:49Z

⚠️ No Changeset found

Latest commit: c15d0f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2024-04-26T20:16:15Z

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	87.98 KB (0%)
packages/react/dist/browser.umd.js	88.28 KB (0%)

khiga8 · 2024-04-26T20:24:20Z

@@ -36,30 +37,29 @@ test.describe('ActionMenu', () => {
 test.describe(theme, () => {


I noticed that this test is under Inactive items but it's visiting the wrong ID, -links-and-actions which is actually a duplicate of another test. Updated!

khiga8 · 2024-04-29T13:32:01Z

The snapshots changed for ActionList bcuz Jonathan's profile picture changed 😅

khiga8 · 2024-04-29T20:13:52Z

I'm assuming the failing tests are expected because the snapshots changed, and will need to be merged in for it to pass.

joshblack · 2024-04-29T21:22:57Z

@khiga8 that's a great point about the CI failing, ideally with update snapshots it should go green before merging since it is checking in the correct images. It may be that there is something flakey going on here, will take a look tomorrow if that's okay 👀 Typically this comes up with animations but I think you have animation: 'disabled' when taking screenshots so I'm not sure what would be causing it here 🤔

khiga8 · 2024-04-30T18:32:34Z

 await page.locator('button', {hasText: 'Open menu'}).waitFor()
 await page.getByRole('button', {name: 'Open menu'}).click()
- expect(await page.screenshot()).toMatchSnapshot(`ActionMenu.Inactive Items.${theme}.png`)
+ expect(await page.screenshot({animations: 'disabled'})).toMatchSnapshot(


Aha! Thank you @joshblack! 🌟

joshblack · 2024-04-30T18:36:35Z

bump @mperrotti when you have a sec to review 👀

* tests: add missing axe coverage for open ActionMenu * Update test * test(vrt): update snapshots * test(vrt): update snapshots * test(vrt): update snapshots * test(ActionMenu): disable animations for snapshot test --------- Co-authored-by: khiga8 <khiga8@users.noreply.github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

khiga8 temporarily deployed to github-pages April 26, 2024 20:16 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-4538 April 26, 2024 20:16 Inactive

khiga8 force-pushed the kh-increase-axe-coverage-to-states branch from fdf4f7d to 08e63e1Compare April 26, 2024 20:22

khiga8 commented Apr 26, 2024
View reviewed changes

khiga8 added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 26, 2024

khiga8 temporarily deployed to github-pages April 26, 2024 20:25 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-4538 April 26, 2024 20:25 Inactive

github-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 26, 2024

primerBottemporarily deployed to github-pages April 26, 2024 20:34 Inactive

github-actionsBottemporarily deployed to storybook-preview-4538 April 26, 2024 20:35 Inactive

khiga8 changed the title ~~tests: add missing snapshot and axe coverage for open component~~tests: add missing snapshot and axe coverage for ActionMenuApr 29, 2024

khiga8 force-pushed the kh-increase-axe-coverage-to-states branch from c5cda68 to 65e5b1eCompare April 29, 2024 12:50

khiga8 added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 29, 2024

khiga8 temporarily deployed to github-pages April 29, 2024 12:53 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-4538 April 29, 2024 12:53 Inactive

github-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 29, 2024

khiga8 added the skip changeset This change does not need a changelog label Apr 29, 2024

primerBottemporarily deployed to github-pages April 29, 2024 13:04 Inactive

github-actionsBottemporarily deployed to storybook-preview-4538 April 29, 2024 13:04 Inactive

khiga8 added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 29, 2024

github-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 29, 2024

primerBottemporarily deployed to github-pages April 29, 2024 13:17 Inactive

github-actionsBottemporarily deployed to storybook-preview-4538 April 29, 2024 13:17 Inactive

khiga8 added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 29, 2024

github-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 29, 2024

primerBottemporarily deployed to github-pages April 29, 2024 13:31 Inactive

khiga8 commented Apr 29, 2024
View reviewed changes

github-actionsBottemporarily deployed to storybook-preview-4538 April 29, 2024 13:32 Inactive

khiga8 marked this pull request as ready for review April 29, 2024 13:34

khiga8 requested review from a team as code owners April 29, 2024 13:34

khiga8 requested a review from mperrotti April 29, 2024 13:34

joshblack approved these changes Apr 29, 2024
View reviewed changes

khiga8 commented Apr 30, 2024
View reviewed changes

joshblack temporarily deployed to github-pages April 30, 2024 18:33 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-4538 April 30, 2024 18:33 Inactive

khiga8 added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label May 1, 2024

khiga8and others added 6 commits May 1, 2024 14:27

tests: add missing axe coverage for open ActionMenu
41cfdbe

Update test
6859349

test(vrt): update snapshots
b3c81b8

test(vrt): update snapshots
e36b422

test(vrt): update snapshots
2408bf8

test(ActionMenu): disable animations for snapshot test
c15d0f9

khiga8 force-pushed the kh-increase-axe-coverage-to-states branch from 4931bfa to c15d0f9Compare May 1, 2024 18:28

khiga8 deployed to github-pages May 1, 2024 18:31 — with GitHub Actions View deployment

github-actionsBottemporarily deployed to storybook-preview-4538 May 1, 2024 18:31 Inactive

mperrotti approved these changes May 1, 2024
View reviewed changes

khiga8 added this pull request to the merge queue May 1, 2024

Merged via the queue into main with commit c860b70May 1, 2024

khiga8 deleted the kh-increase-axe-coverage-to-states branch May 1, 2024 21:04

Navigation Menu

Uh oh!

tests: add missing snapshot and axe coverage for ActionMenu - #4538

tests: add missing snapshot and axe coverage for ActionMenu#4538
khiga8 merged 6 commits into
mainfrom
kh-increase-axe-coverage-to-states

khiga8 commented Apr 26, 2024•
edited
Loading

Uh oh!

changeset-botBot commented Apr 26, 2024•
edited
Loading

Uh oh!

github-actionsBot commented Apr 26, 2024•
edited
Loading

Uh oh!

khiga8Apr 26, 2024•
edited
Loading

Uh oh!

khiga8Apr 29, 2024

Uh oh!

khiga8 commented Apr 29, 2024

Uh oh!

joshblack commented Apr 29, 2024

Uh oh!

khiga8Apr 30, 2024

Uh oh!

joshblack commented Apr 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -36,30 +37,29 @@ test.describe('ActionMenu', () => {
		test.describe(theme, () => {

Uh oh!

Conversation

khiga8 commented Apr 26, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Rollout strategy

Testing & Reviewing

Merge checklist

Uh oh!

changeset-botBot commented Apr 26, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actionsBot commented Apr 26, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

khiga8Apr 26, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

khiga8Apr 29, 2024

Choose a reason for hiding this comment

Uh oh!

khiga8 commented Apr 29, 2024

Uh oh!

joshblack commented Apr 29, 2024

Uh oh!

khiga8Apr 30, 2024

Choose a reason for hiding this comment

Uh oh!

joshblack commented Apr 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

khiga8 commented Apr 26, 2024•
edited
Loading

changeset-botBot commented Apr 26, 2024•
edited
Loading

github-actionsBot commented Apr 26, 2024•
edited
Loading

khiga8Apr 26, 2024•
edited
Loading