Skip to content

fix(Spinner): update visually hidden container to span#4689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshblack merged 2 commits into from
Jun 20, 2024
Merged

fix(Spinner): update visually hidden container to span #4689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
113eb66
fix(Spinner): update visually hidden container to span
joshblack Jun 20, 2024
723217f
chore: update snpashots
joshblack Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/react/src/Spinner/Spinner.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -57,7 +57,11 @@ function Spinner({size: sizeKey = 'medium', srText = 'Loading', 'aria-label': ar
vectorEffect="non-scaling-stroke"
/>
</svg>
{hasHiddenLabel ? <VisuallyHidden id={labelId}>{srText}</VisuallyHidden> : null}
{hasHiddenLabel ? (
<VisuallyHidden as="span" id={labelId}>
{srText}
</VisuallyHidden>
) : null}
</Box>
)
}
Expand Down
4 changes: 2 additions & 2 deletions packages/react/src/__tests__/__snapshots__/Autocomplete.test.tsx.snap
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -402,12 +402,12 @@ exports[`snapshots renders a loading state 1`] = `
vectorEffect="non-scaling-stroke"
/>
</svg>
<div
<span
className="c4"
id=":r1v:"
>
Loading
</div>
</span>
</div>
</div>
</span>,
Expand Down
80 changes: 40 additions & 40 deletions packages/react/src/__tests__/__snapshots__/TextInput.test.tsx.snap
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4128,12 +4128,12 @@ exports[`TextInput renders with a loading indicator 1`] = `
vectorEffect="non-scaling-stroke"
/>
</svg>
<div
<span
className="c6"
id=":rn:"
>
Loading
</div>
</span>
</div>
</div>
</span>
Expand DownExpand Up@@ -4342,12 +4342,12 @@ exports[`TextInput renders with a loading indicator 1`] = `
vectorEffect="non-scaling-stroke"
/>
</svg>
<div
<span
className="c5"
id=":ro:"
>
Loading
</div>
</span>
</div>
</div>
</span>
Expand DownExpand Up@@ -4399,12 +4399,12 @@ exports[`TextInput renders with a loading indicator 1`] = `
vectorEffect="non-scaling-stroke"
/>
</svg>
<div
<span
className="c5"
id=":rp:"
>
Loading
</div>
</span>
</div>
</div>
</span>
Expand DownExpand Up@@ -4614,12 +4614,12 @@ exports[`TextInput renders with a loading indicator 1`] = `
vectorEffect="non-scaling-stroke"
/>
</svg>
<div
<span
className="c6"
id=":rq:"
>
Loading
</div>
</span>
</div>
</div>
</span>
Expand DownExpand Up@@ -4867,12 +4867,12 @@ exports[`TextInput renders with a loading indicator 1`] = `
vectorEffect="non-scaling-stroke"
/>
</svg>
<div
<span
className="c6"
id=":rr:"
>
Loading
</div>
</span>
</div>
</div>
</span>
Expand DownExpand Up@@ -4924,12 +4924,12 @@ exports[`TextInput renders with a loading indicator 1`] = `
vectorEffect="non-scaling-stroke"
/>
</svg>
<div
<span
className="c6"
id=":rs:"
>
Loading
</div>
</span>
</div>
</div>
</span>
Expand DownExpand Up@@ -5177,12 +5177,12 @@ exports[`TextInput renders with a loading indicator 1`] = `
vectorEffect="non-scaling-stroke"
/>
</svg>
<div
<span
className="c6"
id=":rt:"
>
Loading
</div>
</span>
</div>
</div>
</span>
Expand DownExpand Up@@ -5234,12 +5234,12 @@ exports[`TextInput renders with a loading indicator 1`] = `
vectorEffect="non-scaling-stroke"
/>
</svg>
<div
<span
className="c6"
id=":ru:"
>
Loading
</div>
</span>
</div>
</div>
</span>
Expand DownExpand Up@@ -5487,12 +5487,12 @@ exports[`TextInput renders with a loading indicator 1`] = `
vectorEffect="non-scaling-stroke"
/>
</svg>
<div
<span
className="c6"
id=":rv:"
>
Loading
</div>
</span>
</div>
</div>
</span>
Expand DownExpand Up@@ -5544,12 +5544,12 @@ exports[`TextInput renders with a loading indicator 1`] = `
vectorEffect="non-scaling-stroke"
/>
</svg>
<div
<span
className="c6"
id=":r10:"
>
Loading
</div>
</span>
</div>
</div>
</span>
Expand DownExpand Up@@ -5798,12 +5798,12 @@ exports[`TextInput renders with a loading indicator 1`] = `
vectorEffect="non-scaling-stroke"
/>
</svg>
<div
<span
className="c7"
id=":r11:"
>
Loading
</div>
</span>
</div>
</div>
</span>
Expand DownExpand Up@@ -6021,12 +6021,12 @@ exports[`TextInput renders with a loading indicator 1`] = `
vectorEffect="non-scaling-stroke"
/>
</svg>
<div
<span
className="c5"
id=":r12:"
>
Loading
</div>
</span>
</div>
</div>
</span>
Expand DownExpand Up@@ -6108,12 +6108,12 @@ exports[`TextInput renders with a loading indicator 1`] = `
vectorEffect="non-scaling-stroke"
/>
</svg>
<div
<span
className="c5"
id=":r13:"
>
Loading
</div>
</span>
</div>
</div>
</span>
Expand DownExpand Up@@ -6362,12 +6362,12 @@ exports[`TextInput renders with a loading indicator 1`] = `
vectorEffect="non-scaling-stroke"
/>
</svg>
<div
<span
className="c7"
id=":r14:"
>
Loading
</div>
</span>
</div>
</div>
</span>
Expand DownExpand Up@@ -6633,12 +6633,12 @@ exports[`TextInput renders with a loading indicator 1`] = `
vectorEffect="non-scaling-stroke"
/>
</svg>
<div
<span
className="c6"
id=":r15:"
>
Loading
</div>
</span>
</div>
</div>
</span>
Expand DownExpand Up@@ -6720,12 +6720,12 @@ exports[`TextInput renders with a loading indicator 1`] = `
vectorEffect="non-scaling-stroke"
/>
</svg>
<div
<span
className="c6"
id=":r16:"
>
Loading
</div>
</span>
</div>
</div>
</span>
Expand DownExpand Up@@ -6982,12 +6982,12 @@ exports[`TextInput renders with a loading indicator 1`] = `
vectorEffect="non-scaling-stroke"
/>
</svg>
<div
<span
className="c6"
id=":r17:"
>
Loading
</div>
</span>
</div>
</div>
</span>
Expand DownExpand Up@@ -7069,12 +7069,12 @@ exports[`TextInput renders with a loading indicator 1`] = `
vectorEffect="non-scaling-stroke"
/>
</svg>
<div
<span
className="c6"
id=":r18:"
>
Loading
</div>
</span>
</div>
</div>
</span>
Expand DownExpand Up@@ -7338,12 +7338,12 @@ exports[`TextInput renders with a loading indicator 1`] = `
vectorEffect="non-scaling-stroke"
/>
</svg>
<div
<span
className="c6"
id=":r19:"
>
Loading
</div>
</span>
</div>
</div>
</span>
Expand DownExpand Up@@ -7425,12 +7425,12 @@ exports[`TextInput renders with a loading indicator 1`] = `
vectorEffect="non-scaling-stroke"
/>
</svg>
<div
<span
className="c6"
id=":r1a:"
>
Loading
</div>
</span>
</div>
</div>
</span>
Expand Down
Loading