Uh oh!
There was an error while loading. Please reload this page.
IconButton: Add keyshortcuts prop to allow labelling and describing support for keyboard shortcut (through tooltips) - #4707
Merged
Conversation
…ns (through tooltip)
🦋 Changeset detectedLatest commit: 7974ffb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
broccolinisouptemporarily deployed
to
github-pages
July 1, 2024 02:46 — with 
GitHub Actions
Inactive
keyshortcuts prop to allow labelling and describing support for keyboard shortcut (through tooltips)broccolinisoup
marked this pull request as ready for review
July 1, 2024 03:01
broccolinisouptemporarily deployed
to
github-pages
July 1, 2024 03:01 — with GitHub Actions
Inactive
broccolinisouptemporarily deployed
to
github-pages
July 3, 2024 22:44 — with GitHub Actions
Inactive
joshblack
approved these changes
Jul 5, 2024
broccolinisouptemporarily deployed
to
github-pages
July 8, 2024 00:56 — with GitHub Actions
Inactive
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/332131 |
broccolinisoup
enabled auto-merge
July 10, 2024 07:27
langermank
approved these changes
Jul 11, 2024
Merged
This was referenced Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes an addition to the icon button API as it is accepted on https://github.com/github/primer/pull/2650 (internal link only). The
keyshortcutsprop is added to the IconButton component to allow labelling and describing support for keyboard shortcuts through tooltips. This change is beneficial as it provides a more accessible user experience.Changelog
New
keyshortcutsprop to icon buttonsChanged
keyshortcutsprop is present (Only when tooltips are enabled which will be the default behaviour very soon)Rollout strategy
Testing & Reviewing
Merge checklist