Uh oh!
There was an error while loading. Please reload this page.
feat(UnderlineNavItem): add support for icons as React.ReactElement - #4718
Merged
Conversation
🦋 Changeset detectedLatest commit: 83ad76b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
keithamus
approved these changes
Jul 3, 2024
joshblack
enabled auto-merge
July 4, 2024 13:50
Merged
This was referenced Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the
iconprop inUnderlineNavItemto also supportReact.ReactElementin addition toReact.FC.This change will help us with Figma Code Connect files and also opens up the opportunity for the
iconprop to be static as an element which can help with performance.Changelog
New
React.ReactElementto theiconprop forUnderlineNavItemChanged
Removed
Rollout strategy
Testing & Reviewing