Skip to content

Promote PageHeader to Beta 🎉 - #4725

Merged
broccolinisoup merged 8 commits into
mainfrom
promote-pageheader-beta
Jul 19, 2024
Merged

Promote PageHeader to Beta 🎉#4725
broccolinisoup merged 8 commits into
mainfrom
promote-pageheader-beta

Conversation

@broccolinisoup

@broccolinisoupbroccolinisoup commented Jul 9, 2024•
edited
Loading

Copy link
Copy Markdown
Member

We completed the PageHeader work and closed out the epic (internal link only)

Changelog

Changed

  • Move PageHeader to Beta status and update the component accordingly.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

@changeset-bot

changeset-botBot commented Jul 9, 2024•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b89c7f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactMinor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
github-actionsBottemporarily deployed to storybook-preview-4725 July 9, 2024 02:22 Inactive
@github-actions

github-actionsBot commented Jul 9, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js92.36 KB (+1.26% 🔺)
packages/react/dist/browser.umd.js92.66 KB (+1.22% 🔺)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-4725 July 9, 2024 02:31 Inactive
@broccolinisoupbroccolinisoup changed the title Promote PageHeader to BetaPromote PageHeader to Beta 🎉Jul 9, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4725 July 9, 2024 02:47 Inactive
@broccolinisoupbroccolinisoup added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 10, 2024
@broccolinisoupbroccolinisoup removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 15, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4725 July 15, 2024 03:27 Inactive
@broccolinisoup
broccolinisoup marked this pull request as ready for review July 15, 2024 03:37
@broccolinisoup
broccolinisoup requested a review from a team as a code ownerJuly 15, 2024 03:37
broccolinisoup
broccolinisoup commented Jul 15, 2024
View reviewed changes
Comment threadpackages/react/src/PageHeader/PageHeader.docs.json
@broccolinisoupbroccolinisoup changed the title Promote PageHeader to Beta 🎉Promote PageHeader to Alpha 🎉Jul 15, 2024
broccolinisoup
broccolinisoup commented Jul 15, 2024
View reviewed changes
Comment threadpackages/react/src/PageHeader/PageHeader.docs.json Outdated
broccolinisoup
broccolinisoup commented Jul 15, 2024
View reviewed changes
Comment thread.changeset/nice-forks-joke.md
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4725 July 15, 2024 03:48 Inactive
@broccolinisoupbroccolinisoup added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 15, 2024
@broccolinisoupbroccolinisoup removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 15, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4725 July 15, 2024 05:29 Inactive
joshblack
joshblack approved these changes Jul 16, 2024
View reviewed changes

@joshblackjoshblack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

siddharthkp
siddharthkp approved these changes Jul 18, 2024
View reviewed changes

@siddharthkpsiddharthkp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Could even promote to beta

@broccolinisoupbroccolinisoup changed the title Promote PageHeader to Alpha 🎉Promote PageHeader to Beta 🎉Jul 19, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4725 July 19, 2024 03:29 Inactive
@broccolinisoup
broccolinisoup added this pull request to the merge queueJul 19, 2024
Merged via the queue into main with commit 6db8b2fJul 19, 2024
@broccolinisoup
broccolinisoup deleted the promote-pageheader-beta branch July 19, 2024 04:04
@primerprimerBot mentioned this pull request Jul 19, 2024
Merged
@Mapuppy09Mapuppy09 mentioned this pull request Aug 19, 2024
Merged
This was referenced Sep 13, 2024
Open
Open
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siddharthkpsiddharthkpsiddharthkp approved these changes
@joshblackjoshblackjoshblack approved these changes
@jonrohanjonrohanAwaiting requested review from jonrohanjonrohan is a code owner automatically assigned from primer/engineer-reviewers
@mperrottimperrottiAwaiting requested review from mperrotti

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@broccolinisoup@siddharthkp@joshblack