StateLabel: Add labels to icon by siddharthkp · Pull Request #4764 · primer/react

siddharthkp · 2024-07-22T14:21:04Z

Fixeshttps://github.com/github/primer/issues/3496

The issueClosedNotPlanned variant has an icon that differentiates it from issueClosed and pullClosed . The icon has no text alternative and includes aria-hidden="true", so is ignored by screen readers. Screen reader users do not know what the labels 'Draft', 'Open' and 'Closed' refers to, unless context is being provided elsewhere on the page, for example, the component is on an Issue page.

Before:

<spanclass="StateLabel__StateLabelBase-sc-qthdln-0 eDFXzm"><svgaria-hidden="true" focusable="false">...</svg>
Closed
</span>

After:

<spanclass="StateLabel__StateLabelBase-sc-qthdln-0 eDFXzm"><svgrole="img" aria-label="Issue" focusable="false">...</svg>
Closed
</span>

Rollout strategy

Patch release
Minor release
Major release; if selected, include a written rollout or migration plan
None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Added/updated tests
Added/updated documentation
Added/updated previews (Storybook)
Changes are SSR compatible
Tested in Chrome
Tested in Firefox
Tested in Safari
Tested in Edge
(GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

changeset-bot · 2024-07-22T14:21:08Z

🦋 Changeset detected

Latest commit: e7a3e29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-07-22T14:24:52Z

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	92.47 KB (+0.12% 🔺)
packages/react/dist/browser.umd.js	92.68 KB (-0.01% 🔽)

primer-integration · 2024-07-22T15:20:07Z

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/333917

Update from Sid: Integration tests are passing :)

TylerJDev

Looks great! ✨

TylerJDev · 2024-07-23T15:45:43Z

+ issueOpened: 'Issue',
+ pullOpened: 'Pull request',
+ issueClosed: 'Issue',
+ issueClosedNotPlanned: 'Issue',


non-blocking, but would we want to add "not planned" here? (i.e. "Issue, not planned")

Great catch! Thank you ❤️

siddharthkp added 3 commits July 22, 2024 14:22

fix accessibility issue first
cd9966f

stronger types
17a0922

add tests, update snapshots
ea6bc8f

siddharthkp added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 22, 2024

siddharthkp self-assigned this Jul 22, 2024

siddharthkp added the accessibility label Jul 22, 2024

github-actionsBot added the staff Author is a staff member label Jul 22, 2024

siddharthkp added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 22, 2024

siddharthkp mentioned this pull request Jul 22, 2024
StateLabel: Cleanup code #4765
Closed

siddharthkp temporarily deployed to github-pages July 22, 2024 14:25 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-4764 July 22, 2024 14:25 Inactive

github-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 22, 2024

siddharthkp added 3 commits July 22, 2024 17:09

remove unused icon
ddafb9e

remove unrelated changes
13b0499

remove unrelated changes
819706d

siddharthkp temporarily deployed to github-pages July 22, 2024 15:15 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-4764 July 22, 2024 15:15 Inactive

siddharthkp added 2 commits July 22, 2024 18:08

run lint locally (sigh)
af3dc9c

Create wild-actors-jam.md
7b43541

siddharthkp temporarily deployed to github-pages July 22, 2024 16:14 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-4764 July 22, 2024 16:15 Inactive

bring back eslint-disable-line
2fae515

siddharthkp temporarily deployed to github-pages July 22, 2024 16:22 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-4764 July 22, 2024 16:23 Inactive

siddharthkp added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 23, 2024

siddharthkp requested a review from TylerJDev July 23, 2024 10:04

siddharthkp marked this pull request as ready for review July 23, 2024 10:05

siddharthkp requested a review from a team as a code owner July 23, 2024 10:05

TylerJDev approved these changes Jul 23, 2024
View reviewed changes

siddharthkp added this pull request to the merge queue Jul 24, 2024

siddharthkp removed this pull request from the merge queue due to a manual request Jul 24, 2024

add not planned for issueClosedNotPlanned
a79a202

siddharthkp enabled auto-merge July 24, 2024 13:10

siddharthkp temporarily deployed to github-pages July 24, 2024 13:14 — with GitHub Actions Inactive

github-actionsBottemporarily deployed to storybook-preview-4764 July 24, 2024 13:14 Inactive

siddharthkp added 2 commits July 24, 2024 15:17

have to add an awkward member to the types
0df55cd

update snapshots
e7a3e29

siddharthkp deployed to github-pages July 24, 2024 13:22 — with GitHub Actions View deployment

github-actionsBottemporarily deployed to storybook-preview-4764 July 24, 2024 13:23 Inactive

siddharthkp added this pull request to the merge queue Jul 24, 2024

Merged via the queue into main with commit 533f997Jul 24, 2024

siddharthkp deleted the labelled-state-labels branch July 24, 2024 13:45

primerBot mentioned this pull request Jul 24, 2024
Release tracking #4753
Merged

Mapuppy09 mentioned this pull request Aug 19, 2024
[Snyk] Upgrade @primer/react from 36.22.0 to 36.27.0 Mapuppy09/documentation#3
Merged

Navigation Menu

Uh oh!

StateLabel: Add labels to icon - #4764

StateLabel: Add labels to icon#4764
siddharthkp merged 12 commits into
mainfrom
labelled-state-labels

siddharthkp commented Jul 22, 2024•
edited
Loading

Uh oh!

changeset-botBot commented Jul 22, 2024•
edited
Loading

Uh oh!

github-actionsBot commented Jul 22, 2024•
edited
Loading

Uh oh!

primer-integrationBot commented Jul 22, 2024•
edited by siddharthkp
Loading

Uh oh!

TylerJDev left a comment

Uh oh!

TylerJDevJul 23, 2024

Uh oh!

siddharthkpJul 24, 2024•
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

siddharthkp commented Jul 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rollout strategy

Testing & Reviewing

Merge checklist

Uh oh!

changeset-botBot commented Jul 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actionsBot commented Jul 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

primer-integrationBot commented Jul 22, 2024• edited by siddharthkp Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TylerJDev left a comment

Choose a reason for hiding this comment

Uh oh!

TylerJDevJul 23, 2024

Choose a reason for hiding this comment

Uh oh!

siddharthkpJul 24, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

siddharthkp commented Jul 22, 2024•
edited
Loading

changeset-botBot commented Jul 22, 2024•
edited
Loading

github-actionsBot commented Jul 22, 2024•
edited
Loading

primer-integrationBot commented Jul 22, 2024•
edited by siddharthkp
Loading

siddharthkpJul 24, 2024•
edited
Loading