Skip to content

refactor: remove SSRProvider and useSSRSafeId - #4783

Merged
joshblack merged 6 commits into
mainfrom
refactor/remove-ssrprovider
Aug 14, 2024
Merged

refactor: remove SSRProvider and useSSRSafeId#4783
joshblack merged 6 commits into
mainfrom
refactor/remove-ssrprovider

Conversation

@joshblack

@joshblackjoshblack commented Jul 26, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Closeshttps://github.com/github/primer/issues/3664

Changelog

New

Changed

  • Update files to no longer use SSRProvider

Removed

  • Remove the SSRProvider component
  • Remove the useSSRSafeId hook

Rollout strategy

  • Major release; if selected, include a written rollout or migration plan

Consumers can safely drop the SSRProvider from their projects. For useSSRSafeId, they can safely migrate to useId() in React 18

@changeset-bot

changeset-botBot commented Jul 26, 2024•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 55fc0f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactMajor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsgithub-actionsBot added the staff Author is a staff member label Jul 26, 2024
@github-actions

github-actionsBot commented Jul 26, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js95.96 KB (-0.1% 🔽)
packages/react/dist/browser.umd.js96.27 KB (-0.02% 🔽)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-4783 July 26, 2024 18:32 Inactive
@joshblack
joshblack marked this pull request as ready for review August 7, 2024 16:03
@joshblack
joshblack requested a review from a team as a code ownerAugust 7, 2024 16:03
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4783 August 7, 2024 16:07 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4783 August 9, 2024 17:29 Inactive
broccolinisoup
broccolinisoup approved these changes Aug 12, 2024
View reviewed changes

@broccolinisoupbroccolinisoup left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@joshblack
joshblack enabled auto-merge August 12, 2024 14:42
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4783 August 12, 2024 14:46 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4783 August 12, 2024 15:22 Inactive
@joshblack
joshblack added this pull request to the merge queueAug 14, 2024
Merged via the queue into main with commit 7c57f40Aug 14, 2024
@joshblack
joshblack deleted the refactor/remove-ssrprovider branch August 14, 2024 16:09
@primerprimerBot mentioned this pull request Aug 14, 2024
Merged
jonrohan pushed a commit that referenced this pull request Aug 15, 2024
@joshblack@jonrohan
refactor: remove SSRProvider and useSSRSafeId (#4783)
68ad08b
* refactor: remove SSRProvider and useSSRSafeId
* chore: remove unused eslint disables
* chore: remove unused prop
---------
Co-authored-by: Josh Black <joshblack@users.noreply.github.com>
@primerprimerBot mentioned this pull request Oct 18, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@broccolinisoupbroccolinisoupbroccolinisoup approved these changes
@TylerJDevTylerJDevAwaiting requested review from TylerJDevTylerJDev is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

staffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joshblack@broccolinisoup