Skip to content

test(e2e): add vrt for blankslate - #4809

Merged
joshblack merged 2 commits into
mainfrom
test/add-blankslate-e2e-tests
Aug 1, 2024
Merged

test(e2e): add vrt for blankslate#4809
joshblack merged 2 commits into
mainfrom
test/add-blankslate-e2e-tests

Conversation

@joshblack

@joshblackjoshblack commented Aug 1, 2024

Copy link
Copy Markdown
Member

Add VRT for Blankslate component before moving to CSS Modules

Changelog

New

  • Add e2e test for Blankslate for VRT and AAT

Changed

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

@joshblack
joshblack requested a review from a team as a code ownerAugust 1, 2024 20:55
@changeset-bot

changeset-botBot commented Aug 1, 2024•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b710cd9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblackjoshblack added update snapshots 🤖 Command that updates VRT snapshots on the pull request skip changeset This change does not need a changelog labels Aug 1, 2024
@github-actionsgithub-actionsBot added the staff Author is a staff member label Aug 1, 2024
@github-actions

github-actionsBot commented Aug 1, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js95.84 KB (0%)
packages/react/dist/browser.umd.js96.18 KB (0%)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-4809 August 1, 2024 21:00 Inactive
@primer
primerBot requested a review from a team as a code ownerAugust 1, 2024 21:03
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Aug 1, 2024
langermank
langermank approved these changes Aug 1, 2024
View reviewed changes

@langermanklangermank left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@joshblack
joshblack enabled auto-merge August 1, 2024 21:06
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4809 August 1, 2024 21:07 Inactive
@joshblack
joshblack added this pull request to the merge queueAug 1, 2024
Merged via the queue into main with commit 2ab2b3cAug 1, 2024
@joshblack
joshblack deleted the test/add-blankslate-e2e-tests branch August 1, 2024 21:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@langermanklangermanklangermank approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip changesetThis change does not need a changelogstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joshblack@langermank