Uh oh!
There was an error while loading. Please reload this page.
Octicon remediation: aria-label - #4811
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 83fce5d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
siddharthkp
commented
Aug 2, 2024
| > | ||
| <Box display="flex" as={as} size={size} {...rest} alignItems="center" justifyContent="center"> | ||
| <IconComponent size={size} /> | ||
| <IconComponent size={size} aria-label={ariaLabel} /> |
MemberAuthor
There was a problem hiding this comment.
Note for reviewer: Moved aria-label from the container to the icon component
Contributor
size-limit report 📦
|
TylerJDev
approved these changes
Aug 5, 2024
TylerJDev
left a comment
Member
There was a problem hiding this comment.
1 non-blocking comment. Looks good!
Uh oh!
There was an error while loading. Please reload this page.
siddharthkptemporarily deployed
to
github-pages
August 14, 2024 14:31 — with 
GitHub Actions
Inactive
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/338296 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Rollout strategy
Testing & Reviewing
Merge checklist