Uh oh!
There was an error while loading. Please reload this page.
ProgressBar: Remove aria-busy from ProgressBar - #4841
Merged
Conversation
🦋 Changeset detectedLatest commit: 3bf029a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/337288 |
TylerJDev
marked this pull request as ready for review
August 13, 2024 13:46
aria-busy from ProgressBararia-busy from ProgressBarjoshblack
approved these changes
Aug 14, 2024
jonrohan pushed a commit
that referenced
this pull request
Aug 15, 2024
* Update snapshots * Add changeset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closeshttps://github.com/github/primer/issues/3360
It was noted that the usage of
aria-busyonrole="progressbar"is unnecessary, as it is intended for a section of the page that is currently being updated, signaling to screen readers that they should wait before announcing the content.This PR removes the attribute from
ProgressBar.Changelog
New
Removed
aria-busyfromProgressBarRollout strategy
Testing & Reviewing
Merge checklist