Skip to content

Refactor Link, Blankslate, Heading to use :where css - #4858

Merged
jonrohan merged 2 commits into
mainfrom
css_modules_where_usage
Aug 21, 2024
Merged

Refactor Link, Blankslate, Heading to use :where css#4858
jonrohan merged 2 commits into
mainfrom
css_modules_where_usage

Conversation

@jonrohan

Copy link
Copy Markdown
Member

This refactors some css in Link, Blankslate, Heading to use :where selectors for better specificity. This is in alignment with CSS guidelines we're drafting.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@jonrohan
jonrohan requested a review from a team as a code ownerAugust 16, 2024 20:41
@changeset-bot

changeset-botBot commented Aug 16, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c091099

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohanjonrohan added the skip changeset This change does not need a changelog label Aug 16, 2024
@github-actionsgithub-actionsBot added the staff Author is a staff member label Aug 16, 2024
@github-actions

github-actionsBot commented Aug 16, 2024

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js96.2 KB (0%)
packages/react/dist/browser.umd.js96.54 KB (0%)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-4858 August 16, 2024 20:46 Inactive
@jonrohanjonrohan removed the skip changeset This change does not need a changelog label Aug 20, 2024
@jonrohan
jonrohan added this pull request to the merge queueAug 21, 2024
Merged via the queue into main with commit 6c69bffAug 21, 2024
@jonrohan
jonrohan deleted the css_modules_where_usage branch August 21, 2024 00:16
@primerprimerBot mentioned this pull request Aug 21, 2024
@primerprimerBot mentioned this pull request Oct 18, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

staffAuthor is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jonrohan@langermank