Skip to content

Revert "refactor: remove MarkdownEditor and MarkdownViewer (#4782)" - #4860

Merged
siddharthkp merged 1 commit into
mainfrom
revert-4782-refactor/remove-markdowneditor-markdownviewer
Aug 19, 2024
Merged

Revert "refactor: remove MarkdownEditor and MarkdownViewer (#4782)"#4860
siddharthkp merged 1 commit into
mainfrom
revert-4782-refactor/remove-markdowneditor-markdownviewer

Conversation

@siddharthkp

@siddharthkpsiddharthkp commented Aug 19, 2024

Copy link
Copy Markdown
Member

While these components have been upstreamed, the imports from primer/react still exist and can't be deleted without migrating them first

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ba3e5e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp
siddharthkp marked this pull request as ready for review August 19, 2024 10:21
@siddharthkp
siddharthkp requested review from a team as code ownersAugust 19, 2024 10:21
@github-actionsgithub-actionsBot added the staff Author is a staff member label Aug 19, 2024
@siddharthkp
siddharthkp removed the request for review from emilybrickAugust 19, 2024 10:22
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js96.3 KB (0%)
packages/react/dist/browser.umd.js96.59 KB (0%)

@siddharthkp
siddharthkp added this pull request to the merge queueAug 19, 2024
Merged via the queue into main with commit d4276baAug 19, 2024
@siddharthkp
siddharthkp deleted the revert-4782-refactor/remove-markdowneditor-markdownviewer branch August 19, 2024 16:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

staffAuthor is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@siddharthkp@langermank