Uh oh!
There was an error while loading. Please reload this page.
Update Label font weight to match Rails component - #4865
Merged
Conversation
🦋 Changeset detectedLatest commit: c011dd2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Label font weight to match Rails componentContributor
size-limit report 📦
|
anandfresh
approved these changes
Aug 21, 2024
camertron
marked this pull request as ready for review
August 21, 2024 17:01
jonrohan
approved these changes
Aug 22, 2024
camertron
enabled auto-merge
August 22, 2024 18:47
camertron
disabled auto-merge
August 22, 2024 18:47
camertron
enabled auto-merge
August 22, 2024 20:14
mperrotti
approved these changes
Aug 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closeshttps://github.com/github/primer/issues/3871
Changelog
No API changes.
New
Changed
The font weight of
Labelcomponents has been changed from bold to semibold to match the Rails component.Removed
Rollout strategy
Testing & Reviewing
None, this change is visual-only.
Merge checklist
- [ ] Added/updated tests- [ ] Added/updated documentation- [ ] Added/updated previews (Storybook)- [ ] Changes are SSR compatible- [ ] Tested in Chrome- [ ] Tested in Firefox- [ ] Tested in Safari- [ ] Tested in Edge- [ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)