Uh oh!
There was an error while loading. Please reload this page.
feat(Banner): update Banner to use CSS Modules behind feature flag - #4913
Merged
Conversation
🦋 Changeset detectedLatest commit: 4bf2a22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
joshblacktemporarily deployed
to
github-pages
September 3, 2024 20:53 — with 
GitHub Actions
Inactive
joshblacktemporarily deployed
to
github-pages
September 4, 2024 21:09 — with GitHub Actions
Inactive
jonrohan
reviewed
Sep 5, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
joshblacktemporarily deployed
to
github-pages
September 9, 2024 21:08 — with GitHub Actions
Inactive
joshblacktemporarily deployed
to
github-pages
September 13, 2024 18:09 — with GitHub Actions
Inactive
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
joshblacktemporarily deployed
to
github-pages
September 16, 2024 20:34 — with GitHub Actions
Inactive
…anner-to-css-modules
…imer/react into refactor/update-banner-to-css-modules
joshblack
enabled auto-merge
September 16, 2024 20:55
github-merge-queueBot
removed this pull request from the merge queue due to no response for status checks
Sep 16, 2024
Uh oh!
There was an error while loading. Please reload this page.
13 tasks
TylerJDev pushed a commit
that referenced
this pull request
Sep 23, 2024
…4913) * feat(Banner): update Banner to use CSS Modules behind feature flag * chore: add changeset * chore: remove autogenerated pnpm packageManager change * chore: fix stylelint errors * chore: add back in underline for fallback case * refactor: update autofix and eslint warning * chore: update class order for tests * chore: fix stylelint errors * Update packages/react/src/Banner/Banner.module.css Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com> --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com> Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closeshttps://github.com/github/primer/issues/3882
Changelog
New
Changed
Bannerto use CSS Modules behind a feature flagLinkto no longer forwardunderlineto the underlying nodeRemoved
Rollout strategy