Uh oh!
There was an error while loading. Please reload this page.
Bug fix: invisible Button variant missing background color when disabled - #4928
Merged
Conversation
🦋 Changeset detectedLatest commit: 105426a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
langermanktemporarily deployed
to
github-pages
September 6, 2024 16:45 — with 
GitHub Actions
Inactive
Contributor
size-limit report 📦
|
langermanktemporarily deployed
to
github-pages
September 6, 2024 17:04 — with GitHub Actions
Inactive
langermank
marked this pull request as ready for review
September 6, 2024 17:56
jonrohan
approved these changes
Sep 6, 2024
| cursor: not-allowed; | ||
| box-shadow: none; | ||
| color: primer.fg.disabled; | ||
| background-color: var(--button-invisible-bgColor-disabled,undefined); |
Member
There was a problem hiding this comment.
What should the fallback value here be? Seems to be showing up as undefined 🤔
ContributorAuthor
There was a problem hiding this comment.
Oh weird... lemme fix that
langermanktemporarily deployed
to
github-pages
September 6, 2024 18:10 — with GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix: invisible button variant missing bg color when disabled