Uh oh!
There was an error while loading. Please reload this page.
fix(Banner): update alignment of actions when Banner is dismissible - #4954
Merged
Conversation
🦋 Changeset detectedLatest commit: 4b3a582 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joshblacktemporarily deployed
to
github-pages
September 12, 2024 16:28 — with 
GitHub Actions
Inactive
Contributor
size-limit report 📦
|
joshblack
marked this pull request as ready for review
September 12, 2024 16:57
joshblack
commented
Sep 12, 2024
MemberAuthor
Note: just realized with the snapshots that the buttons are not in the right order, looking at this now 👀 |
…com:primer/react into fix/update-banner-actions-when-hidden-title
joshblacktemporarily deployed
to
github-pages
September 12, 2024 17:14 — with GitHub Actions
Inactive
langermank
approved these changes
Sep 12, 2024
Uh oh!
There was an error while loading. Please reload this page.
siddharthkp
approved these changes
Sep 13, 2024
Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
joshblack
enabled auto-merge
September 13, 2024 15:33
TylerJDev pushed a commit
that referenced
this pull request
Sep 23, 2024
…4954) * fix(Banner): update alignment of actions when Banner is dismissible * chore: add changeset * test(vrt): update snapshots * fix(Banner): update actions order * test(vrt): update snapshots * Update .changeset/spicy-eggs-melt.md Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com> --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com> Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closeshttps://github.com/github/primer/issues/3957
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing