Uh oh!
There was an error while loading. Please reload this page.
feat(react): remove deprecated components from main entrypoint - #4992
Merged
Conversation
🦋 Changeset detectedLatest commit: 9060a98 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joshblacktemporarily deployed
to
github-pages
September 19, 2024 19:14 — with 
GitHub Actions
Inactive
Contributor
size-limit report 📦
|
joshblacktemporarily deployed
to
github-pages
September 24, 2024 17:04 — with GitHub Actions
Inactive
…rimer/react into feat/remove-deprecated-from-deprecated
joshblackhad a problem deploying
to
github-pages
September 24, 2024 17:06 — with GitHub Actions
Error
joshblack
marked this pull request as ready for review
September 24, 2024 17:06
joshblacktemporarily deployed
to
github-pages
September 24, 2024 17:09 — with GitHub Actions
Inactive
Uh oh!
There was an error while loading. Please reload this page.
siddharthkp
approved these changes
Sep 25, 2024
siddharthkp
left a comment
Member
There was a problem hiding this comment.
I see you tested it with dotcom, that's the main thing here :)
…cated-from-deprecated
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/344709 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closeshttps://github.com/github/primer/issues/4012
Closeshttps://github.com/github/primer/issues/4013
Closeshttps://github.com/github/primer/issues/4014
Closeshttps://github.com/github/primer/issues/4015
With https://github.com/github/github/pull/343108 merged, and the lint rule enabled, we can now remove deprecated components from the main entrypoint.
Changelog
New
Changed
Removed
Rollout strategy
We have created a rule to forbid importing these components from
@primer/reactand have migrated them to@primer/react/deprecatedupstream and enabled that rule. Removing these exports should have no effect as a result as all instances of imports have been removed.